Re: [PATCH v5 2/3] usb: cdns3: Add CIX Sky1 glue driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/11/2026 08:49, Hongliang Yang (杨宏亮) wrote:
> +	data->rcsu_axi_base = devm_platform_ioremap_resource_byname(pdev, "axi");
> +	if (IS_ERR(data->rcsu_axi_base))
> +		return PTR_ERR(data->rcsu_axi_base);
> +	data->rcsu_ctst_base = devm_platform_ioremap_resource_byname(pdev, "status");
> +	if (IS_ERR(data->rcsu_ctst_base))
> +		return PTR_ERR(data->rcsu_ctst_base);
> +	data->reset = devm_reset_control_get_exclusive(&pdev->dev, "core");
> +	if (IS_ERR(data->reset)) {
> +		ret = PTR_ERR(data->reset);
> +		dev_err(dev, "get reset error:%d\n", ret);
> +		return ret;
> +	}
> +	data->preset = devm_reset_control_get_exclusive(&pdev->dev, "apb");
> +	if (IS_ERR(data->preset)) {
> +		ret = PTR_ERR(data->preset);
> +		dev_err(dev, "get reset error:%d\n", ret);
> +		return ret;
> +	}
> +	platform_set_drvdata(pdev, data);
> +	data->dev = dev;
> +	ret = of_alias_get_id(dev->of_node, "usb");

NAK, undocumented ABI. Drop entire alias and do not sneak such stuff in
the future.

> +	if (ret == -ENODEV) {
> +		if (device_property_read_u32(dev, "id", &ret))
> +			ret = -ENODEV;
> +	}
> +	if (ret < 0 || ret >=  SKY1_USB_S5_NUM) {
> +		dev_err(dev, "get alias failed.\n");
> +		return ret;
> +	}
> +	data->id = ret;
> +	data->usb_syscon = syscon_regmap_lookup_by_phandle(dev->of_node,
> +							   "cix,usb-syscon");
> +	if (IS_ERR(data->usb_syscon)) {
> +		dev_err(dev, "Unable to get cix,usb-syscon regmap");
> +		return PTR_ERR(data->usb_syscon);

From where did you copy such syntax of error handling?



Best regards,
Krzysztof