* usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201
@ 2017-12-12 16:47 Daniel Thompson
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2017-12-12 16:47 UTC (permalink / raw)
To: Mathias Nyman
Cc: Daniel Thompson, linux-usb, Greg Kroah-Hartman, Ard Biesheuvel,
linux-kernel, patches, stable
When plugging in a USB webcam I see the following message:
xhci_hcd 0000:04:00.0: WARN Successful completion on short TX: needs
XHCI_TRUST_TX_LENGTH quirk?
handle_tx_event: 913 callbacks suppressed
All is quiet again with this patch (and I've done a fair but of soak
testing with the camera since).
Cc: <stable@vger.kernel.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
---
drivers/usb/host/xhci-pci.c | 3 +++
1 file changed, 3 insertions(+)
--
2.14.2
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 7ef1274ef7f7..1aad89b8aba0 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -177,6 +177,9 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
xhci->quirks |= XHCI_TRUST_TX_LENGTH;
xhci->quirks |= XHCI_BROKEN_STREAMS;
}
+ if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
+ pdev->device == 0x0014)
+ xhci->quirks |= XHCI_TRUST_TX_LENGTH;
if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
pdev->device == 0x0015)
xhci->quirks |= XHCI_RESET_ON_RESUME;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201
@ 2017-12-12 16:54 Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-12-12 16:54 UTC (permalink / raw)
To: Daniel Thompson
Cc: Mathias Nyman, linux-usb, Greg Kroah-Hartman,
linux-kernel@vger.kernel.org, Patch Tracking,
stable@vger.kernel.org
On 12 December 2017 at 16:47, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> When plugging in a USB webcam I see the following message:
> xhci_hcd 0000:04:00.0: WARN Successful completion on short TX: needs
> XHCI_TRUST_TX_LENGTH quirk?
> handle_tx_event: 913 callbacks suppressed
>
> All is quiet again with this patch (and I've done a fair but of soak
> testing with the camera since).
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
I have been setting this quirk manually for ages on my kernel command
line, for the same reason (MS HD Webcam), and with the same positive
result, so
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> drivers/usb/host/xhci-pci.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 7ef1274ef7f7..1aad89b8aba0 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -177,6 +177,9 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> xhci->quirks |= XHCI_TRUST_TX_LENGTH;
> xhci->quirks |= XHCI_BROKEN_STREAMS;
> }
> + if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
> + pdev->device == 0x0014)
> + xhci->quirks |= XHCI_TRUST_TX_LENGTH;
> if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
> pdev->device == 0x0015)
> xhci->quirks |= XHCI_RESET_ON_RESUME;
> --
> 2.14.2
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201
@ 2017-12-13 11:07 Mathias Nyman
0 siblings, 0 replies; 3+ messages in thread
From: Mathias Nyman @ 2017-12-13 11:07 UTC (permalink / raw)
To: Ard Biesheuvel, Daniel Thompson
Cc: Mathias Nyman, linux-usb, Greg Kroah-Hartman,
linux-kernel@vger.kernel.org, Patch Tracking,
stable@vger.kernel.org
On 12.12.2017 18:54, Ard Biesheuvel wrote:
> On 12 December 2017 at 16:47, Daniel Thompson
> <daniel.thompson@linaro.org> wrote:
>> When plugging in a USB webcam I see the following message:
>> xhci_hcd 0000:04:00.0: WARN Successful completion on short TX: needs
>> XHCI_TRUST_TX_LENGTH quirk?
>> handle_tx_event: 913 callbacks suppressed
>>
>> All is quiet again with this patch (and I've done a fair but of soak
>> testing with the camera since).
>>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> I have been setting this quirk manually for ages on my kernel command
> line, for the same reason (MS HD Webcam), and with the same positive
> result, so
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks, adding
-Mathias
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-13 11:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-13 11:07 usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201 Mathias Nyman
-- strict thread matches above, loose matches on Subject: below --
2017-12-12 16:54 Ard Biesheuvel
2017-12-12 16:47 Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).