Linux USB
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: "'Bjørn Mork'" <bjorn@mork.no>, "Oliver Neukum" <oneukum@suse.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	USB list <linux-usb@vger.kernel.org>
Subject: RE: question on random MAC in usbnet
Date: Sun, 19 Nov 2023 11:09:33 +0000	[thread overview]
Message-ID: <64dfec9e75a744cf8e7f50807140ba9a@AcuMS.aculab.com> (raw)
In-Reply-To: <87zfzeexy8.fsf@miraculix.mork.no>

From: Bjørn Mork
> Sent: 16 November 2023 11:32
...
> > Do you think that behavior should be changed to using
> > a separate random MAC for each device that requires it?
> 
> I'm in favour.
> 
> I could be wrong, but I don't expect anything to break if we did that.
> The current static address comes from eth_random_addr() in any case, so
> the end result as seen from the mini drivers should be identical.  The
> difference will be seen in userspace and surrounding equipment, And
> those should be for the better.

It might cause grief when a USB device 'bounces' [1].
At the moment it will pick up the same 'random' MAC address.
But afterwards it will change.

So you might want to save the MAC on device removal and
re-use it on the next insert.

[1] We ended up putting the USB interface inside a 'bond'
in order to stop the interface everything was using
randomly disappearing due to common-mode noise on the
USB data lines causing a disconnect.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

  parent reply	other threads:[~2023-11-19 11:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 10:14 question on random MAC in usbnet Oliver Neukum
2023-11-16 11:31 ` Bjørn Mork
2023-11-16 12:32   ` Oliver Neukum
2023-11-19 11:09   ` David Laight [this message]
2023-11-19 16:13     ` Andrew Lunn
2023-11-20 11:06     ` Oliver Neukum
2023-11-20 16:48     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64dfec9e75a744cf8e7f50807140ba9a@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=bjorn@mork.no \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox