linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-usb@vger.kernel.org,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Daniel Drake" <drake@endlessm.com>,
	"Dmitry Fleytman" <dmitry@daynix.com>,
	"Eugene Korenevsky" <ekorenevsky@gmail.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Günter Röck" <linux@roeck-us.net>,
	"Johan Hovold" <johan@kernel.org>,
	"Mathias Nyman" <mathias.nyman@linux.intel.com>,
	"Peter Chen" <peter.chen@nxp.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
Date: Wed, 6 Dec 2017 17:13:25 +0100	[thread overview]
Message-ID: <659939f3-da51-0cfd-2eb2-8a726cb1a42f@users.sourceforge.net> (raw)

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 6 Dec 2017 17:00:18 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/usb/core/hub.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 7ccdd3d4db84..9fbb908e9552 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
 	 */
 	clear = kmalloc(sizeof *clear, GFP_ATOMIC);
 	if (clear == NULL) {
-		dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
 		/* FIXME recover somehow ... RESET_TT? */
 		return -ENOMEM;
 	}

             reply	other threads:[~2017-12-06 16:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 16:13 SF Markus Elfring [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-12-06 16:45 USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Alan Stern
2017-12-06 16:57 Greg Kroah-Hartman
2017-12-06 17:27 Geert Uytterhoeven
2017-12-06 17:51 SF Markus Elfring
2017-12-06 20:05 Joe Perches
2017-12-06 20:20 Geert Uytterhoeven
2017-12-06 21:18 Alan Stern
2017-12-06 21:33 SF Markus Elfring
2017-12-06 22:02 Alan Stern
2017-12-07  7:40 Geert Uytterhoeven
2017-12-07  8:35 Dan Carpenter
2017-12-07  8:45 Geert Uytterhoeven
2017-12-07  8:56 Greg Kroah-Hartman
2017-12-07  9:17 Oliver Neukum
2017-12-07  9:30 Dan Carpenter
2017-12-07 13:38 SF Markus Elfring
2017-12-07 15:12 Alan Stern
2017-12-07 16:20 Joe Perches
2017-12-07 20:51 Dan Carpenter
2017-12-07 21:26 Alan Stern
2017-12-08  7:43 Geert Uytterhoeven
2017-12-08 11:11 Dan Carpenter
2017-12-08 12:00 SF Markus Elfring
2017-12-08 17:42 Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=659939f3-da51-0cfd-2eb2-8a726cb1a42f@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=dmitry@daynix.com \
    --cc=drake@endlessm.com \
    --cc=ekorenevsky@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mathias.nyman@linux.intel.com \
    --cc=peter.chen@nxp.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).