From: Krishna Kurapati PSSNV <krishna.kurapati@oss.qualcomm.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] usb: typec: hd3ss3220: Enable VBUS based on ID pin state
Date: Thu, 6 Nov 2025 20:53:44 +0530 [thread overview]
Message-ID: <65a910ff-61ae-41a8-b5aa-9a7a119fb13d@oss.qualcomm.com> (raw)
In-Reply-To: <aQx1WVif-vgN0_T-@kuha.fi.intel.com>
On 11/6/2025 3:46 PM, Heikki Krogerus wrote:
>> struct regulator *vbus;
>>
>> vbus = devm_of_regulator_get_optional(...
>> if (IS_ERR(vbus) && vbus != ERR_PTR(-ENODEV))
>> return PTR_ERR(vbus);
>>
>> hd3ss3220->vbus = vbus;
>
> Sorry, that has to be:
>
> hd3ss3220->vbus = vbus == ERR_PTR(-ENODEV) ? NULL : vbus;
>
>
Thanks for the review Heikki.
Will update the suggestions in next revision.
Regards,
Krishna,
next prev parent reply other threads:[~2025-11-06 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 16:48 [PATCH v6 0/2] Implement vbus support for HD3SS3220 port controller Krishna Kurapati
2025-11-02 16:48 ` [PATCH v6 1/2] dt-bindings: usb: ti,hd3ss3220: Add support for VBUS based on ID state Krishna Kurapati
2025-11-02 16:48 ` [PATCH v6 2/2] usb: typec: hd3ss3220: Enable VBUS based on ID pin state Krishna Kurapati
2025-11-06 10:05 ` Heikki Krogerus
2025-11-06 10:16 ` Heikki Krogerus
2025-11-06 15:23 ` Krishna Kurapati PSSNV [this message]
2025-11-06 15:31 ` Krishna Kurapati PSSNV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a910ff-61ae-41a8-b5aa-9a7a119fb13d@oss.qualcomm.com \
--to=krishna.kurapati@oss.qualcomm.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox