Re: [PATCH 2/2] usb: dwc3: core: Prevent phy suspend during init

[Chris Morgan <macroalpha82@gmail.com>]

On Wed, Oct 30, 2024 at 03:10:34PM +0200, Roger Quadros wrote:
> Hi Chris,
> 
> On 30/10/2024 00:49, Thinh Nguyen wrote:
> > Hi,
> > 
> > On Tue, Oct 29, 2024, Chris Morgan wrote:
> >> Sorry, to be specific it was the fix that causes the issues I'm now
> >> observing. When I explicitly revert commit
> >> 705e3ce37bccdf2ed6f848356ff355f480d51a91 things start working again
> >> for me. With that commit in place, however, suspend fails for me.
> > 
> > Ok, Roger's patch is causing issue on your platform and the $subject
> > patch? Can you provide more details on your test sequence?
> > 
> > * What does "no longer able to suspend" mean exactly (what error?)
> > * What mode is your usb controller?
> > * Is there any device connected while going into suspend?
> > * Can you provide dwc3 regdump?
> 
> Commit 705e3ce37bccdf2ed6f848356ff355f480d51a91 will enable
> DWC3_GUSB2PHYCFG_SUSPHY in DWC3_GUSB2PHYCFG(i)
> and DWC3_GUSB3PIPECTL_SUSPHY in DWC3_GUSB3PIPECTL(i) during
> system suspend path, unless snps,dis_u2_susphy_quirk or
> snps,dis_u3_susphy_quirk is set.
> 
> I see rK356x.dtsi has snps,dis_u2_susphy_quirk;
> Does adding snps,dis_u3_susphy_quirk resolve the issue?

I'm afraid it does not fix the issue. Specifically when I do
"systemctl suspend" the device begins to suspend but freezes with the
kernel log output via serial console listed previously. Note I have
console enabled in suspend. Additionally button input no longer
works at this point.

Specifically, I'm testing this with the Anbernic RG353P device based on
the Rockchip RK3566 SoC, in case you're curious.

I'm not able to get you a register dump post suspend attempt as the
system completely freezes, however I can get you a dump prior to
suspend if that will help?

Thank you,
Chris

> 
> cheers,
> -roger
> > 
> > Thanks,
> > Thinh
> > 
> >>
> >> On Fri, Oct 25, 2024 at 5:40 PM Thinh Nguyen <Thinh.Nguyen@synopsys.com> wrote:
> >>>
> >>> Hi,
> >>>
> >>> On Fri, Oct 25, 2024, Chris Morgan wrote:
> >>>>
> >>>> This patch seems to break system suspend on at least the Rockchip
> >>>> RK3566 platform. I noticed that I was no longer able to suspend
> >>>> and git bisect led me to this patch.
> >>>>
> >>>> My kernel message log shows the following, at which point it freezes
> >>>> and does not allow me to resume from suspend:
> >>>>
> >>>> [   27.235049] PM: suspend entry (deep)
> >>>> [   27.871641] Filesystems sync: 0.636 seconds
> >>>> [   27.885320] Freezing user space processes
> >>>> [   27.886932] Freezing user space processes completed (elapsed 0.001 seconds)
> >>>> [   27.887642] OOM killer disabled.
> >>>> [   27.887981] Freezing remaining freezable tasks
> >>>> [   27.889655] Freezing remaining freezable tasks completed (elapsed 0.001 seconds)
> >>>>
> >>>> Thank you,
> >>>> Chris
> >>>
> >>> Did you try out Roger's fix?
> >>> 705e3ce37bcc ("usb: dwc3: core: Fix system suspend on TI AM62 platforms")
> >>>
> >>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=705e3ce37bccdf2ed6f848356ff355f480d51a91__;!!A4F2R9G_pg!ZXQdR2uLykSD67_3JSm0RZHuyJ7IVnw5EvmYvLnPsf3dDEilv5ZgHD9GX7gZr52t0H7oFKifzAEhbdK8EGYzmSji2UI$ 
> >>>
> >>> BR,
> >>> Thinh
>