From: "Slark Xiao" <slark_xiao@163.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH] net: usb: qmi_wwan: Add support for Cinterion MV32
Date: Thu, 11 Aug 2022 16:07:06 +0800 (CST) [thread overview]
Message-ID: <6775a759.2696.1828bf15897.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <87mtccl1ir.fsf@miraculix.mork.no>
At 2022-08-10 20:35:24, "Bjørn Mork" <bjorn@mork.no> wrote:
>"Slark Xiao" <slark_xiao@163.com> writes:
>> At 2022-08-10 17:28:51, "Slark Xiao" <slark_xiao@163.com> wrote:
>>
>>>I have a concern, if Cinterion or other Vendors, like Quectel, use other
>>>chip (such as intel, mediateck and so on), this methods may won't work,
>>
>> My bad. QMI_WWAN driver is designed for Qualcomm based chips only,
>> right?
>
>Yes, but your concern is still valid if any of them re-use ff/ff/50 for
>something which is not RMNET/QMI. We do not want this driver to start
>matching a non-Qualcomm based device.
>
>>>because they share a same VID. Also this may be changed once Qualcomm
>>>update the protocol patterns for future chip.
>
>Yes, that' a risk since we have no knowledge of Qualcomm's plans or
>thoughts around this. It's all pure guesswork from my side. But as
>such, it doesn't differ from the rest of this driver :-) Qualcomm can
>change whatever they want and we'll just have to follow up with whatever
>is required. Like what happened when raw-ip became mandatory.
>
>I do find it unlikely that Qualcomm will ever change the meaning of this
>pattern now that they've started using it. That would not make any
>sense. If they need to create a new vendor specific function type, then
>they can just use one of the "free" protocol numbers (and also subclass
>if they run out of protocol numbers).
>
>But it's your call. If you want to play it safe and keep the VID+PID
>matching, then I'm fine with that too.
>
>
>Bjørn
Then please help me apply it directly. There is no more commit
request for MV32 serials if they don't update base line.
Thanks.
next prev parent reply other threads:[~2022-08-11 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 1:45 [PATCH] net: usb: qmi_wwan: Add support for Cinterion MV32 Slark Xiao
2022-08-10 6:55 ` Bjørn Mork
2022-08-10 9:28 ` Slark Xiao
2022-08-10 9:41 ` Slark Xiao
2022-08-10 12:35 ` Bjørn Mork
2022-08-11 8:07 ` Slark Xiao [this message]
2022-08-11 8:27 ` Bjørn Mork
2022-08-11 16:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6775a759.2696.1828bf15897.Coremail.slark_xiao@163.com \
--to=slark_xiao@163.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox