From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Tudor Ambarus - M18064 <Tudor.Ambarus@microchip.com>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
Cristian Birsan - M91496 <Cristian.Birsan@microchip.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: usb: host: ohci-at91: fix request of irq for optional gpio
Date: Mon, 15 Oct 2018 10:58:34 +0200 [thread overview]
Message-ID: <6897566c-7a8b-e071-70df-8f730e93f087@microchip.com> (raw)
On 15/10/2018 at 10:34, Tudor Ambarus - M18064 wrote:
> atmel,oc-gpio is optional. Request it's irq only when atmel,oc is set
> in device tree.
>
> devm_gpiod_get_index_optional returns NULL if -ENOENT. Check its
> return value for NULL before error, because it is more probably that
> atmel,oc is not set.
>
> This fixes the following errors on boards where atmel,oc is not set in
> device tree:
> [ 0.960000] at91_ohci 500000.ohci: failed to request gpio "overcurrent" IRQ
> [ 0.960000] at91_ohci 500000.ohci: failed to request gpio "overcurrent" IRQ
> [ 0.970000] at91_ohci 500000.ohci: failed to request gpio "overcurrent" IRQ
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Yes, indeed:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks, best regards,
Nicolas
> ---
> Based on https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git,
> usb-next branch.
>
> drivers/usb/host/ohci-at91.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index e98673954020..ec6739ef3129 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -551,6 +551,8 @@ static int ohci_hcd_at91_drv_probe(struct platform_device *pdev)
> pdata->overcurrent_pin[i] =
> devm_gpiod_get_index_optional(&pdev->dev, "atmel,oc",
> i, GPIOD_IN);
> + if (!pdata->overcurrent_pin[i])
> + continue;
> if (IS_ERR(pdata->overcurrent_pin[i])) {
> err = PTR_ERR(pdata->overcurrent_pin[i]);
> dev_err(&pdev->dev, "unable to claim gpio \"overcurrent\": %d\n", err);
>
next reply other threads:[~2018-10-15 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 8:58 Nicolas Ferre [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-15 8:34 usb: host: ohci-at91: fix request of irq for optional gpio Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6897566c-7a8b-e071-70df-8f730e93f087@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Cristian.Birsan@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).