Linux USB
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Olivier Kaloudoff <olivier.kaloudoff@gmail.com>,
	linux-usb@vger.kernel.org
Cc: stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
	usb-storage@lists.one-eyed-alien.net, stable@vger.kernel.org
Subject: Re: [PATCH v4] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
Date: Mon, 16 Nov 2026 13:00:50 +0100	[thread overview]
Message-ID: <69bbe579-d296-4bef-bd0f-da30f12b466f@suse.com> (raw)
In-Reply-To: <20261114174929.53871-1-olivier.kaloudoff@gmail.com>



On 14.11.26 18:49, Olivier Kaloudoff wrote:
> The ASMedia chip detection in uas_use_uas_driver() assumes that every
> device with idVendor/idProduct 174c:5106 or 174c:55aa reporting a
> config.MaxPower of 0 is an ASM1153 with working UAS.
> 
> ASMT135x bridges (iProduct "ASMT135x") share the same 174c:55aa id and
> also report MaxPower == 0, so they take the "ASM1153, do nothing"
> path — but their UAS implementation is broken:
> 
> - The first READ(16) issued by sd probing times out after 30 s;
>    enumeration only completes after a uas_eh_abort_handler plus a full
>    uas_eh_host_reset_handler cycle:
> 
>      scsi 3:0:0:0: Direct-Access  ASMT     ASMT135x        0  PQ: 0 ANSI: 6
>      sd 3:0:0:0: [sdb] tag#26 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD IN
>      sd 3:0:0:0: [sdb] tag#26 CDB: Read(16) 88 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00
>      scsi host3: uas_eh_host_reset_handler start
>      usb 6-2: reset SuperSpeed USB device number 2 using xhci_hcd
>      scsi host3: uas_eh_host_reset_handler success
> 
> - Under concurrent load the bridge stalls: all inflight commands (20+
>    UAS tags in the captured incident, mixed READ(16)/WRITE(16)) hit the
>    30 s UAS timeout in the same event, forcing repeated abort/reset
>    cycles and eventually a USB disconnect.  Writes dropped mid-flight
>    during these resets returned zeros to the filesystem (observed as
>    XFS metadata corruption on the mounted volume).
> 
> - Sequential-write throughput is ~45 MiB/s under UAS versus ~136 MiB/s
>    after disabling UAS (usb-storage BOT mode), which is fully stable:
>    several tens of GiB written without a single error.
> 
> - Bulk reads of healthy LBA ranges do work under UAS (~190 MiB/s, no
>    errors); the failure pattern is command-timeout at enumeration and
>    under queue depth / write load, not a broken transfer path.
> 
> An extended soak was also run at maintainer request: the device was
> rebound to uas and pushed with ~640 GiB of mixed I/O over ~2h45
> (randrw/seqwrite at queue depths 8-32, disk util ~100%).  Result: zero
> uas_eh events; the queue-depth wedge did not reproduce on demand.  The
> enumeration stall did reproduce once more at the first UAS probe and
> self-recovered via host reset.  Per the maintainer, an inconclusive
> load test still warrants the blacklist given the filesystem-loss risk.
> 
> Since 174c:55aa is shared across several ASMedia bridges and enclosure
> rebrandings, distinguish the ASMT135x by its product string — the same
> approach used for the HIKSEMI MD202 check a few lines below.  The
> product strings of working bridges using the same id ("ASM1053E",
> "ASM1153", "ASM1153E", "ASM1351", vendor rebrands such as "YZWY_TECH")
> do not contain "ASMT135", so the match is safe.
> 
> Verified on an ORICO C10 enclosure (iManufacturer "ASMT", iProduct
> "ASMT135x", bcdDevice 1.00, stock firmware) attached through an Alpine
> Ridge TB3 dock: with the equivalent usb-storage quirks parameter
> (174c:55aa:u) the device is completely stable.
> 
> Signed-off-by: Olivier Kaloudoff <olivier.kaloudoff@gmail.com>Acked-by: Oliver Neukum <oneukum@suse.com>

      reply	other threads:[~2026-11-16 12:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 17:49 [PATCH v4] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa) Olivier Kaloudoff
2026-11-16 12:00 ` Oliver Neukum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69bbe579-d296-4bef-bd0f-da30f12b466f@suse.com \
    --to=oneukum@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=olivier.kaloudoff@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox