linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Purohit, Kaushal" <kaushal.purohit@ti.com>
To: Oliver Neukum <oneukum@suse.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: issues with cdc ncm host class driver
Date: Mon, 3 Apr 2023 10:18:58 +0000	[thread overview]
Message-ID: <6a8da52391f349ffbdaf2ab6d81e5cff@ti.com> (raw)
In-Reply-To: <28ec4e65-647f-2567-fb7d-f656940d4e43@suse.com>

Oliver, Thanks for the quick confirmation. Tracked in kernel Bugzilla by "Bug 217290".

-----Original Message-----
From: Oliver Neukum <oneukum@suse.com> 
Sent: Monday, April 3, 2023 3:39 PM
To: Purohit, Kaushal <kaushal.purohit@ti.com>; stable@vger.kernel.org
Cc: regressions@lists.linux.dev; linux-usb@vger.kernel.org
Subject: [EXTERNAL] Re: issues with cdc ncm host class driver

On 03.04.23 08:14, Purohit, Kaushal wrote:
> Hi,
> 

Hi,

> Referring to patch with commit ID (*e10dcb1b6ba714243ad5a35a11b91cc14103a9a9*).
> 
> This is a spec violation for CDC NCM class driver. Driver clearly says 
> the significance of network capabilities. (snapshot below)
> 
> However, with the mentioned patch these values are disrespected and commands specific to these capabilities are sent from the host regardless of device' capabilities to handle them.

Right. So for your device, the correct behavior would be to do nothing, wouldn't it? The packets would be delivered and the host needs to filter and discard unrequested packets.

> Currently we are setting these bits to 0 indicating no capabilities on our device and still we observe that Host (Linux kernel host cdc driver) has been sending requests specific to these capabilities.
> 
> Please let me know if there is a better way to indicate host that device does not have these capabilities.

no you are doing things as they are supposed to be done and the host is at fault. This kernel bug needs to be fixed.

	Regards
		Oliver


  reply	other threads:[~2023-04-03 10:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <da37bb0d43de465185c10aad9924f265@ti.com>
2023-04-03 10:09 ` issues with cdc ncm host class driver Oliver Neukum
2023-04-03 10:18   ` Purohit, Kaushal [this message]
2023-04-04 10:33   ` Linux regression tracking (Thorsten Leemhuis)
2023-06-20 14:16     ` Linux regression tracking (Thorsten Leemhuis)
2023-06-27  6:40       ` [EXTERNAL] " Purohit, Kaushal
2023-04-05 10:53 ` Oliver Neukum
2023-04-28  8:45   ` Linux regression tracking (Thorsten Leemhuis)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a8da52391f349ffbdaf2ab6d81e5cff@ti.com \
    --to=kaushal.purohit@ti.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).