From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7131BC33C8C for ; Tue, 7 Jan 2020 18:06:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43C202073D for ; Tue, 7 Jan 2020 18:06:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hak7QrKO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728454AbgAGSGL (ORCPT ); Tue, 7 Jan 2020 13:06:11 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55393 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728366AbgAGSGL (ORCPT ); Tue, 7 Jan 2020 13:06:11 -0500 Received: by mail-wm1-f65.google.com with SMTP id q9so490684wmj.5; Tue, 07 Jan 2020 10:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=TwyqbtixwfDzppKFaI3w4i8nG7c7b8pJMNXC0vFuA/8=; b=hak7QrKONk+QHhTwUiKGycoyKENk56hZB0bxZmV2lrgltNbvfPhNC4tW4nfoO/cYK7 RIYJYjgSjF9JFvo1U7FkNnuOdKL7Msh3IPwaMY4eyAjKcGrsE/d4TvxKIXBmLc/aquJj 2UotjacloQrE872HHQA65Q5aLRuuEr23wdXztDdnhAKtRrZlXGBqC0sB8QfWwZpT0/gt LDVf95slcQa31IcX9SDh8cHSnvM9X8CjlUrs8dDwFMg0iJAlC/whWX0h6g2ZhJutttxX 9sLbEfpBZtLyy5XMGUyhDCufkUBLQE4kirrJwNn6qnD4hHcQuMOpppKOnDlgrb/9uH6s M0Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TwyqbtixwfDzppKFaI3w4i8nG7c7b8pJMNXC0vFuA/8=; b=bU3wtok7EGHlawC341i0yYaPbCBwP5X6FrcbnkbQp1aaS/b5xdeejCQbY7rVIaratv RJ2X9Ip/K89uD89RDTjqqGTn/WVykgHh14gAz7o3B38RMy5yf47McEksyU/ehiYW5955 0sRMe2yrSNK27DqtWC8DS2fmSSgA7zgn75//8kxzdAgUvK2aDLpjXDa+8QvfSlzh8fCV eSJ2hygIDsC5q9n5fmnfj4jYDPbDIzHAhDT1f4CPKpVJvDz6UsJNA12N0cZVGfPEh8dw RX1uyXBhrZeYaKdhkV+WtnY+s7kTmlidi3sPoSjQmm/utpxgM+nPoIEXiCt1tC96rt3R 1kaA== X-Gm-Message-State: APjAAAWPXBTxNZMXvjiL53zk+Ynovk1XsphBsWCGpyaHqQLLC7tuAEfH ajsheDmmM1SuLEkQJQoAjWaiZzv0 X-Google-Smtp-Source: APXvYqxEBb32tYns6M/I4BzfkOxhu71xtZitfjJweSdd+xVfOkC3VOJNBWhZ3FAHzZWRTdjujr8yLg== X-Received: by 2002:a05:600c:1003:: with SMTP id c3mr286431wmc.47.1578420369265; Tue, 07 Jan 2020 10:06:09 -0800 (PST) Received: from [192.168.8.147] (118.164.185.81.rev.sfr.net. [81.185.164.118]) by smtp.gmail.com with ESMTPSA id c68sm477362wme.13.2020.01.07.10.06.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2020 10:06:08 -0800 (PST) Subject: Re: [RPI 3B+ / TSO / lan78xx ] To: Stefan Wahren , Eric Dumazet , RENARD Pierre-Francois , nsaenzjulienne@suse.de, woojung.huh@microchip.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org References: <5267da21-8f12-2750-c0c5-4ed31b03833b@gmail.com> <78b94ba2-9a87-78bb-8916-e6ef5a0668ae@gmail.com> <863777f2-3a7b-0736-d0a4-d9966bea3f96@gmail.com> From: Eric Dumazet Message-ID: <6a8ec9cb-b56d-a788-1460-e9f0d9dd8f5f@gmail.com> Date: Tue, 7 Jan 2020 10:06:07 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 1/7/20 9:30 AM, Stefan Wahren wrote: > Hi Eric, > > Am 07.01.20 um 18:04 schrieb Eric Dumazet: >> >> >> I doubt TSO and SACK have a serious generic bug like that. >> >> Most likely the TSO implementation on the driver/NIC has a bug . > > Yes, the issue isn't reproducible with the Raspberry Pi 3B and the same > kernel (without +). The main difference between both boards is the > different ethernet USB chip: > > Raspberry Pi 3B: smsc95xx > Raspberry Pi 3B+: lan78xx > >> >> Anyway you do not provide a kernel version, I am not sure what you expect from us. > > It's Linux 5.4.7 (arm64) as in the provided github link. I asked > Pierre-Francois to report this issue here, so the issue get addressed > properly. Currently this very old bug not fixed in mainline and the > Raspberry Pi vendor tree uses a workaround (disable TSO). This is puzzling. Bug seems trivial enough :/