From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Michał Pecio" <michal.pecio@gmail.com>,
linux-usb@vger.kernel.org,
"Niklas Neronin" <niklas.neronin@linux.intel.com>
Subject: Re: [PATCH 23/24] usb: xhci: add warning message specifying which Set TR Deq failed
Date: Wed, 21 May 2025 16:22:34 +0300 [thread overview]
Message-ID: <6d0c69a6-1349-469d-9f7f-6731aa77f28f@linux.intel.com> (raw)
In-Reply-To: <2025052136-apostle-floral-9c23@gregkh>
>>>
>>> Is printing this pointer actually useful? It doesn't tell why
>>> the error happened. It will not relate to other messages - the
>>> command failed, so dequeue stays at its old position.
>> Printing the DMA address has turned out to be quite useful, quickly shows corner
>> cases like end or beginning of ring segment, or address missing upper 32 bits.
>
> Printing kernel addresses is not allowed. If you really want to do
> this, use the proper printk flag for it (%p I think).
These are all DMA bus addresses used by the device.
Wasn't aware those are bad as well
>
>> Comparable with the "trb not in TD" error messages
>
> Should that be fixed too? Again, don't print kernel addresses please,
> people consider that an information leak.
Yes, there are several places that print DMA addresses using %llx in the xhci driver
We can change those to %pad, or some index
Thanks
Mathias
next prev parent reply other threads:[~2025-05-21 13:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 13:55 [PATCH 00/24] xhci features for usb-next Mathias Nyman
2025-05-15 13:55 ` [PATCH 01/24] usb: xhci: Don't log transfer ring segment list on errors Mathias Nyman
2025-05-15 13:55 ` [PATCH 02/24] usb: xhci: Add debugfs support for xHCI port bandwidth Mathias Nyman
2025-05-15 13:56 ` [PATCH 03/24] usb: xhci: relocate pre-allocation initialization Mathias Nyman
2025-05-15 13:56 ` [PATCH 04/24] usb: xhci: move device slot enabling register write Mathias Nyman
2025-05-15 13:56 ` [PATCH 05/24] usb: xhci: move command ring pointer write Mathias Nyman
2025-05-15 13:56 ` [PATCH 06/24] usb: xhci: refactor xhci_set_cmd_ring_deq() Mathias Nyman
2025-05-15 13:56 ` [PATCH 07/24] usb: xhci: move DCBAA pointer write Mathias Nyman
2025-05-15 13:56 ` [PATCH 08/24] usb: xhci: move doorbell array pointer assignment Mathias Nyman
2025-05-15 13:56 ` [PATCH 09/24] usb: xhci: move enabling of USB 3 device notifications Mathias Nyman
2025-05-15 13:56 ` [PATCH 10/24] usb: xhci: remove error handling from xhci_add_interrupter() Mathias Nyman
2025-05-15 13:56 ` [PATCH 11/24] usb: xhci: move initialization of the primary interrupter Mathias Nyman
2025-05-15 13:56 ` [PATCH 12/24] usb: xhci: add individual allocation checks in xhci_mem_init() Mathias Nyman
2025-05-15 13:56 ` [PATCH 13/24] usb: xhci: cleanup xhci_mem_init() Mathias Nyman
2025-05-15 13:56 ` [PATCH 14/24] usb: xhci: set requested IMODI to the closest supported value Mathias Nyman
2025-05-15 13:56 ` [PATCH 15/24] usb: xhci: improve Interrupt Management register macros Mathias Nyman
2025-05-15 13:56 ` [PATCH 16/24] usb: xhci: guarantee that IMAN register is flushed Mathias Nyman
2025-05-15 13:56 ` [PATCH 17/24] usb: xhci: remove '0' write to write-1-to-clear register Mathias Nyman
2025-05-15 13:56 ` [PATCH 18/24] usb: xhci: rework Event Ring Segment Table Size mask Mathias Nyman
2025-05-15 13:56 ` [PATCH 19/24] usb: xhci: rework Event Ring Segment Table Address mask Mathias Nyman
2025-05-15 13:56 ` [PATCH 20/24] usb: xhci: cleanup IMOD register comments Mathias Nyman
2025-05-15 13:56 ` [PATCH 21/24] usb: xhci: rename 'irq_pending' to 'iman' Mathias Nyman
2025-05-15 13:56 ` [PATCH 22/24] usb: xhci: rename 'irq_control' to 'imod' Mathias Nyman
2025-05-15 13:56 ` [PATCH 23/24] usb: xhci: add warning message specifying which Set TR Deq failed Mathias Nyman
2025-05-16 12:43 ` Michał Pecio
2025-05-16 14:32 ` Neronin, Niklas
2025-05-19 14:33 ` Mathias Nyman
2025-05-21 10:34 ` Greg KH
2025-05-21 13:22 ` Mathias Nyman [this message]
2025-05-15 13:56 ` [PATCH 24/24] xhci: Add host support for eUSB2 double isochronous bandwidth devices Mathias Nyman
2025-05-16 0:27 ` Thinh Nguyen
2025-05-16 0:40 ` Thinh Nguyen
2025-05-16 11:58 ` Mathias Nyman
2025-05-17 0:16 ` Thinh Nguyen
2025-05-21 10:36 ` [PATCH 00/24] xhci features for usb-next Greg KH
2025-05-21 13:24 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d0c69a6-1349-469d-9f7f-6731aa77f28f@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.pecio@gmail.com \
--cc=niklas.neronin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox