From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Zhu Wang <wangzhu9@huawei.com>,
gregkh@linuxfoundation.org, robh@kernel.org,
stern@rowland.harvard.edu, aaro.koskinen@iki.fi,
linux-usb@vger.kernel.org
Subject: Re: [PATCH -next] usb: gadget: udc: gr_udc: Do not check 0 for platform_get_irq()
Date: Thu, 3 Aug 2023 14:17:33 +0300 [thread overview]
Message-ID: <6d53b741-2d20-92f8-e024-c91a4754e459@gmail.com> (raw)
In-Reply-To: <20230803064129.74313-1-wangzhu9@huawei.com>
On 8/3/23 9:41 AM, Zhu Wang wrote:
> Since platform_get_irq() never returned zero, so it need not to check
> whether it returned zero, and we use the return error code of
> platform_get_irq() to replace the current return error code.
>
> Please refer to the commit a85a6c86c25b ("driver core: platform: Clarify
> that IRQ 0 is invalid") to get that platform_get_irq() never returned
> zero.
>
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
[...]
Same comments as to the MUSB driver...
MBR, Sergey
prev parent reply other threads:[~2023-08-03 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 6:41 [PATCH -next] usb: gadget: udc: gr_udc: Do not check 0 for platform_get_irq() Zhu Wang
2023-08-03 11:17 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d53b741-2d20-92f8-e024-c91a4754e459@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=wangzhu9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).