From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E52C31E4C for ; Fri, 14 Jun 2019 12:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C49F20850 for ; Fri, 14 Jun 2019 12:23:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727635AbfFNMXv (ORCPT ); Fri, 14 Jun 2019 08:23:51 -0400 Received: from mga01.intel.com ([192.55.52.88]:23216 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727362AbfFNMXv (ORCPT ); Fri, 14 Jun 2019 08:23:51 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 05:23:51 -0700 X-ExtLoop1: 1 Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.164]) ([10.237.72.164]) by orsmga007.jf.intel.com with ESMTP; 14 Jun 2019 05:23:50 -0700 Subject: Re: [PATCH] usb: xhci: dbc: get rid of global pointer To: Felipe Balbi Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org References: <20190611172416.12473-1-felipe.balbi@linux.intel.com> From: Mathias Nyman Message-ID: <6daea602-58e3-3811-f1f6-6a9464d8af2e@linux.intel.com> Date: Fri, 14 Jun 2019 15:26:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190611172416.12473-1-felipe.balbi@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 11.6.2019 20.24, Felipe Balbi wrote: > If we happen to have two XHCI controllers with DbC capability, then > there's no hope this will ever work as the global pointer will be > overwritten by the controller that probes last. > > Avoid this problem by keeping the tty_driver struct pointer inside > struct xhci_dbc. > > Fixes: dfba2174dc42 usb: xhci: Add DbC support in xHCI driver > Cc: # v4.16+ > Signed-off-by: Felipe Balbi > --- Thanks, adding to queue -Mathias