From: Mathias Nyman <mathias.nyman@intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Oliver Neukum <oneukum@suse.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xhci: Prevent runtime suspend all the time with XHCI_RESET_ON_RESUME quirk
Date: Mon, 4 May 2020 13:13:02 +0300 [thread overview]
Message-ID: <6fca4532-b4a2-9730-bd96-5ac15357f752@intel.com> (raw)
In-Reply-To: <88A0FF32-C7D7-4E49-8470-FE23401371BD@canonical.com>
On 4.5.2020 13.02, Kai-Heng Feng wrote:
>
>
>> On May 4, 2020, at 17:47, Oliver Neukum <oneukum@suse.com> wrote:
>>
>> Am Montag, den 04.05.2020, 17:19 +0800 schrieb Kai-Heng Feng:
>>> Etron EJ168 USB 3.0 Host Controller stops working after S3, if it was
>>> runtime suspended previously:
>>> [ 370.080359] pci 0000:02:00.0: can't change power state from D3cold to D0 (config space inaccessible)
>>
>> Apparently this controller has issues with D3cold
>>
>>> [ 370.080477] xhci_hcd 0000:04:00.0: can't change power state from D3cold to D0 (config space inaccessible)
>>> [ 370.080532] pcieport 0000:00:1c.0: DPC: containment event, status:0x1f05 source:0x0200
>>> [ 370.080533] pcieport 0000:00:1c.0: DPC: ERR_FATAL detected
>>> [ 370.080536] xhci_hcd 0000:04:00.0: can't change power state from D3hot to D0 (config space inaccessible)
>>> [ 370.080552] xhci_hcd 0000:04:00.0: AER: can't recover (no error_detected callback)
>>> [ 370.080566] usb usb3: root hub lost power or was reset
>>> [ 370.080566] usb usb4: root hub lost power or was reset
>>> [ 370.080572] xhci_hcd 0000:04:00.0: Host halt failed, -19
>>> [ 370.080574] xhci_hcd 0000:04:00.0: Host not accessible, reset failed.
>>> [ 370.080575] xhci_hcd 0000:04:00.0: PCI post-resume error -19!
>>> [ 370.080586] xhci_hcd 0000:04:00.0: HC died; cleaning up
>>>
>>> This can be fixed by not runtime suspend the controller at all.
>>>
>>> So instead of conditionally runtime suspend the controller, always
>>> prevent runtime suspend with XHCI_RESET_ON_RESUME quirk.
>>
>> What does that do to other controllers that can do runtime suspend
>> under the current scheme?
>
> Ok, I'll add a new quirk specific to this controller.
>
> Kai-Heng
Host shouldn't runtime suspend by default unless set by userspace, or
it has XHCI_DEFAULT_PM_RUNTIME_ALLOW quirk set.
-Mathias
next prev parent reply other threads:[~2020-05-04 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 9:19 [PATCH] xhci: Prevent runtime suspend all the time with XHCI_RESET_ON_RESUME quirk Kai-Heng Feng
2020-05-04 9:47 ` Oliver Neukum
2020-05-04 10:02 ` Kai-Heng Feng
2020-05-04 10:13 ` Mathias Nyman [this message]
2020-05-04 10:21 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fca4532-b4a2-9730-bd96-5ac15357f752@intel.com \
--to=mathias.nyman@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox