Re: [PATCH 7/7] usb: xhci: rename Port Register Set pointer in struct 'xhci_port'

["Neronin, Niklas" <niklas.neronin@linux.intel.com>]

On 05/09/2025 5.40, Peter Chen (CIX) wrote:
> On 25-09-04 17:42:20, Niklas Neronin wrote:
>> Rename the Host Controller USB Port Register Set pointer in the 'xhci_port'
>> struct from "addr" to "port_reg". This new name accurately reflects the
>> purpose of the pointer.
>>
> 
> I am also implementing a wrapper that needs to cover all PORTSC
> registers access, it is used to cover the controllers which have some
> problems to access PORTSC when the USB PHY switches to DP for USB/DP
> altmode scenario, current USB core and xHCI core access USB3 PORTSC
> at some places (detail could see the changes you do below) if controller
> supports both USB2 and USB3, even the USB3 connection is not there.
> 
> I am thinking is it possible you add a wrapper like
> xhci_port_readl/xhci_port_writel for all PORTSC access, otherwise I
> also need to change all places you make.
> 

Yes, I will add a read PORTSC functions, in version 2.
I am on vacation this week, so v2 will be ready next week.

Best Regards,
Niklas