Re: [PATCH] xhci: reduce xhci_handshake timeout in xhci_reset

Pavan Kondeti
2022-02-15T03:38:29Z

On Mon, Feb 14, 2022 at 06:45:30PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 2/14/22 2:04 PM, Pavankumar Kondeti wrote:
>
> > From: Daehwan Jung <dh10.jung@samsung.com>
> >
> > xhci_reset() is called with interrupts disabled. Waiting 10 seconds for
> > controller reset and controller ready operations can be fatal to the
> > system when controller is timed out. Reduce the timeout to 1 second
> > and print a error message when the time out happens.
>
> Waiting 1 second with IRQs diabled is also hardly acceptable. :-/
>

Thanks for making this point clear.

Having debugged several performance issue related to preemption and irqs
disabled, I can't agree more. We had to chase down the code that disable
scheduling for more than 2-3 msec in our downstream kernels on a mobile
SoC.

However in this case, we run into timeout very very rarely in which case
10 sec timeout is causing system hang like symptops which we want to avoid.

Thanks,
Pavan