From: Roger Quadros <rogerq@ti.com>
To: Pawel Laszczak <pawell@cadence.com>, <balbi@kernel.org>
Cc: <peter.chen@nxp.org>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kurahul@cadence.com>
Subject: Re: [PATCH] usb: cdns3: platform_get_irq_byname_optional instead platform_get_irq_byname
Date: Fri, 2 Oct 2020 11:53:57 +0300 [thread overview]
Message-ID: <722fa58e-604b-bc34-d404-caf7939bb176@ti.com> (raw)
In-Reply-To: <20200930065758.23740-1-pawell@cadence.com>
Pawel,
On 30/09/2020 09:57, Pawel Laszczak wrote:
> To avoid duplicate error information patch replaces platform_get_irq_byname
> into platform_get_irq_byname_optional.
What is duplicate error information?
>
> A change was suggested during reviewing CDNSP driver by Chunfeng Yun.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
> drivers/usb/cdns3/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> index a0f73d4711ae..a3f6dc44cf3a 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -465,7 +465,7 @@ static int cdns3_probe(struct platform_device *pdev)
>
> cdns->xhci_res[1] = *res;
>
> - cdns->dev_irq = platform_get_irq_byname(pdev, "peripheral");
> + cdns->dev_irq = platform_get_irq_byname_optional(pdev, "peripheral");
As per DT binding document, these are mandatory properties
- interrupts: Interrupts used by cdns3 controller:
"host" - interrupt used by XHCI driver.
"peripheral" - interrupt used by device driver
"otg" - interrupt used by DRD/OTG part of driver
for dr_mode == "otg" -> all 3 are mandatory.
for dr_mode == "host" -> "otg" and "peripheral" IRQs are not required.
for dr_mode == "periphearal" -> "otg" and "host" IRQs are not required.
> if (cdns->dev_irq == -EPROBE_DEFER)
> return cdns->dev_irq;
>
> @@ -477,7 +477,7 @@ static int cdns3_probe(struct platform_device *pdev)
> return PTR_ERR(regs);
> cdns->dev_regs = regs;
>
> - cdns->otg_irq = platform_get_irq_byname(pdev, "otg");
> + cdns->otg_irq = platform_get_irq_byname_optional(pdev, "otg");
> if (cdns->otg_irq == -EPROBE_DEFER)
> return cdns->otg_irq;
>
>
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-10-02 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 6:57 [PATCH] usb: cdns3: platform_get_irq_byname_optional instead platform_get_irq_byname Pawel Laszczak
2020-09-30 7:24 ` Pawel Laszczak
2020-10-02 8:53 ` Roger Quadros [this message]
2020-10-02 9:08 ` Pawel Laszczak
2020-10-02 10:06 ` Roger Quadros
2020-10-05 5:54 ` Pawel Laszczak
2020-10-05 8:43 ` Roger Quadros
2020-10-05 8:49 ` Pawel Laszczak
2020-10-07 3:12 ` Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=722fa58e-604b-bc34-d404-caf7939bb176@ti.com \
--to=rogerq@ti.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox