From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F1281EB9F9 for ; Thu, 20 Mar 2025 19:49:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742500156; cv=none; b=oxXpqBWcxoAyOdcuIIuWqFXPZWzfd6IRWKNZGH50ijPNCg8HAiC3izXLNGUH9s1VW91mlBp6/uRFQZGW2l2zRR4j+pbwKIh4d4Ac1E45AMjICcbd9fIYfaerUYWqPM+cjPCuL49kjoXQj1Ci32YXXPpVhmTTFMGDvBFw4Kxg2dU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742500156; c=relaxed/simple; bh=KFQpkAFiRwi5JvgaGkgUS3XMJL1ly4AUO7zYJrorCgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ir2/hUyt2v3XYURBCjV3G00x4HbqEoKw1XrqRbdQHsq+SwXH3QojcveswZd0yJVaxEqrO9mNRRUQ7EzPcev2EjkSlSCuFU06nNTWTTSrmpkNFCC12PoDGaYnHoyNRHpygUWOtdU7MZ4KKwC/PCFcOL+o7tM8A5aPvz/zxOQSa/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=V+qHwmxS; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="V+qHwmxS" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-22401f4d35aso25748985ad.2 for ; Thu, 20 Mar 2025 12:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742500154; x=1743104954; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pMRUp5Qyehm/UHkEF8vmSOmZ085ovglSkPUzMHQiUvE=; b=V+qHwmxSsRylMh683u3emKvxWHIoiCfzb0J94EAEEx6slNleLpoQOa0wGz8bnfQFiW 533g0RUXQ+d02JJehu12OU3dPX5/BzcU0gOovi75YSPHGhuxRTbu0NEsR85EYRWYi6Gb s1tc4FRq32rncn5rnYyrIbij2DWdtAnqUIPixMhf7LkaViRD2+33exE2AbA6Xi8/6Rvp KAJvDrFVwEq/hfHb8FWHz1mwmwfPWLqejW86PsHBkCuR7sGB+0S40tJxX0FGILYhXCCQ BnQe+Opx0+bD3g3ip6zx8UsPdSc5L7/+mHDGVzk+z+H8m/EyGZISyB0kYOlWFGBCrHLO UT0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742500154; x=1743104954; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pMRUp5Qyehm/UHkEF8vmSOmZ085ovglSkPUzMHQiUvE=; b=QFDH9+prS+13+2i/3tVf+lSz6fANjRtHDFH/ObDY63GcQL8c6K1bRW6pgnkAq5U4fV 5FyvnlQP3zNi+UHcALCSFb+GJI621/igK0vUGBZp1NbjLj/GxSCRFDeh48/PpWIVOlB8 x8qxr0bm24ygFDrzSUoYCGlg1qChGowJHiv++zRyyGF6WyGXodThkIMvDGv7tGe2CeZJ aV+u/6pojsUfIcbyg3lWLcsNkG7zlhzoljfKmv1CBDz3X/lP4rDBSCq0d7xXWzoklR74 dBk6styiLcBk1VgNH4yBGmnBHHolQDccxWtncNpfoMjGcJUW8ymx8u7gEDVxitYUniuR EyQA== X-Forwarded-Encrypted: i=1; AJvYcCVOB6hthVvxxwBGN/667y3UGerwVzIlJ7ramyxjpbrjCdG32A3vEGQYZRYZN0XYOiuBoCmZVjqLpuc=@vger.kernel.org X-Gm-Message-State: AOJu0YwIrRsEx3FEE6ylP9QrNwPD9sETNXIUTYvVcZ7mBatwNCp+KSsG LON/Nz3olRQjVqpVibkb6flpGeMaMWWq3Ghd95jZbtjehZSy1zNfcEfg3XC40A== X-Gm-Gg: ASbGncsEIJima4OruFiMlVzByuYnCJ9wEfZlCNq4q2XntmdE7jhmSY6KyHUPdE+QJko J2+EYvM2Msv7pLOO6QHIcK6n0SDDJCeSupAF5PoRP1Hfv/kKTQ2oBT2lCq1Qnc1NnaJmRUtrxYN L5RvxDXNOQdQzOto+F+IznSWMNBsVu8mEbgpqE5nuDHCKO9a8W/svR1xXhnnQJ79z/J4iNqT5QZ WHY1k7P50763M3YY6H5vnufucre24miOhWoPRvVX2TqYmxcYe+BXz4dhPa7+EvNSz2L2YQscxyd 7OlT+NGwfKBh805to+zhAaxqrXh9ksX4xpRrVqr8jDgzZJSPrR7rOU8Ia6WDRnO7DGZYfQMLUsb 278PcaP+rZAsP5IRIBp27i3y0zoakbLmIO/OIR5gv+5Q= X-Google-Smtp-Source: AGHT+IHyrk2bDjkLhMnhglpF2WvxGIuU+CuD3iaUBnBbz39xc/6Rxc5vq7lRwV1BiFP3IbQR23VrGQ== X-Received: by 2002:a05:6a00:4b12:b0:736:755b:8317 with SMTP id d2e1a72fcca58-73905a501e4mr1105162b3a.21.1742500153484; Thu, 20 Mar 2025 12:49:13 -0700 (PDT) Received: from ?IPV6:2a00:79e0:2e14:7:c50a:4138:6122:653a? ([2a00:79e0:2e14:7:c50a:4138:6122:653a]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390611d1dasm210916b3a.106.2025.03.20.12.49.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Mar 2025 12:49:12 -0700 (PDT) Message-ID: <747d9492-b3be-46b0-9e26-5ba45f2e6662@google.com> Date: Thu, 20 Mar 2025 12:49:11 -0700 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] dt-bindings: connector: add fixed-batteries property To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Badhri Jagan Sridharan , Sebastian Reichel , Heikki Krogerus , "Rafael J. Wysocki" , Len Brown , Pavel Machek , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, RD Babiera , Kyle Tso References: <20250312-batt_ops-v1-0-88e0bb3129fd@google.com> <20250312-batt_ops-v1-1-88e0bb3129fd@google.com> <20250313-tidy-kakapo-of-abundance-eebf91@krzk-bin> <85c6de6a-f8b4-4e4e-8fa2-da53816abc89@google.com> <3a33dab7-87b2-4b74-b138-e368d4cbc358@kernel.org> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: <3a33dab7-87b2-4b74-b138-e368d4cbc358@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Krzysztof, On 3/16/25 9:49 AM, Krzysztof Kozlowski wrote: > On 15/03/2025 01:56, Amit Sunil Dhamne wrote: >> Hi Krzysztof, >> >> On 3/13/25 1:48 AM, Krzysztof Kozlowski wrote: >>> On Wed, Mar 12, 2025 at 04:42:01PM -0700, Amit Sunil Dhamne wrote: >>>> Add a new "fixed-batteries" DT property to connector class. This >>>> property is populated with nodes associated with battery type power >>>> supplies powering the USB PD connector. This is needed by the Type-C >>>> Port Manager (TCPM) to query psy properties which are used to feed >>> What is "psy" in terms of bindings? >> In terms of bindings this should be a phandle to a device that >> owns/manages the battery (whose driver will eventually call >> devm_power_supply_register to register the battery). This could be a > So a charger? Please rephrain from putting Linux names into the bindings > description. Noted, thanks! >> fuel-guage ("sprd,sc2731-fgu", say), charger ("ti,bq24190") or a >> platform device ("cw2015") containing "monitored-battery" property to >> manage the simple battery. > >>>> Battery_Status & Battery_Capacity AMS. >>>> >>>> Signed-off-by: Amit Sunil Dhamne >>>> --- >>>> Documentation/devicetree/bindings/connector/usb-connector.yaml | 8 ++++++++ >>>> Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 + >>>> 2 files changed, 9 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml >>>> index 11e40d225b9f3a0d0aeea7bf764f1c00a719d615..5e15bc060f5a2cfce842f83de738f1e8bae3ce2d 100644 >>>> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml >>>> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml >>>> @@ -300,6 +300,14 @@ properties: >>>> $ref: /schemas/types.yaml#/definitions/uint8-array >>>> maxItems: 4 >>>> >>>> + fixed-batteries: >>>> + description: Contains references to nodes associated with battery type power >>>> + supplies powering the USB PD device. These batteries are fixed type and >>> What is a "battery type power supply"? If you just link here batteries, >>> then we have type for it - monitored-battery - but I doubt connector has >>> direct connection to the battery. >> Regarding "nodes associated with battery type power supplies", I meant >> something like a fuel guage or a charger OR platform device with >> "monitored-battery" that will manage the battery lifecycle. If I use >> monitored-battery for this, I will be restricted to only querying 1 >> simple battery. Also, I don't mean PD connector device to be a fuel >> guage or charger that manages a specific battery. It should just be able >> to query any FG/Chg for the battery status to relay that info to the >> connector's port partner. >> >> The intent of the patchset & this change is for the USB Type C protocol >> manager module (that consumes these bindings) to be able to get info > The intent should be rather to accurately describe hardware and maybe > that's the problem - you focus how to bend it for your drivers. Acknowledged! Thanks, Amit > > > Best regards, > Krzysztof