From: Lars Melin <larsm17@gmail.com>
To: Giacinto Cifelli <gciofono@gmail.com>,
linux-usb@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] option: added support for Thales Cinterion MV31 option port.
Date: Mon, 23 Nov 2020 15:33:57 +0700 [thread overview]
Message-ID: <75d9e32b-416b-d084-9718-7b766e8ce1fc@gmail.com> (raw)
In-Reply-To: <981fe0c1-58be-21b8-0e6b-bd19d0b26ce5@gmail.com>
+ johan
On 11/23/2020 15:20, Lars Melin wrote:
> On 11/19/2020 18:59, Giacinto Cifelli wrote:
>> There is a single option port in this modem, and it is used as debug port
>>
>> Signed-off-by: Giacinto Cifelli <gciofono@gmail.com>
>> ---
>> drivers/usb/serial/option.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> index 54ca85cc920d..3ad86a6e8487 100644
>> --- a/drivers/usb/serial/option.c
>> +++ b/drivers/usb/serial/option.c
>> @@ -424,6 +424,7 @@ static void option_instat_callback(struct urb *urb);
>> #define CINTERION_PRODUCT_AHXX_2RMNET 0x0084
>> #define CINTERION_PRODUCT_AHXX_AUDIO 0x0085
>> #define CINTERION_PRODUCT_CLS8 0x00b0
>> +#define CINTERION_PRODUCT_EXS82 0x006c
>> /* Olivetti products */
>> #define OLIVETTI_VENDOR_ID 0x0b3c
>> @@ -1908,6 +1909,8 @@ static const struct usb_device_id option_ids[] = {
>> { USB_DEVICE(SIEMENS_VENDOR_ID, CINTERION_PRODUCT_HC25_MDMNET) },
>> { USB_DEVICE(SIEMENS_VENDOR_ID, CINTERION_PRODUCT_HC28_MDM) },
>> /* HC28 enumerates with Siemens or Cinterion VID depending on FW
>> revision */
>> { USB_DEVICE(SIEMENS_VENDOR_ID, CINTERION_PRODUCT_HC28_MDMNET) },
>> + { USB_DEVICE_INTERFACE_CLASS(CINTERION_VENDOR_ID,
>> CINTERION_PRODUCT_EXS82, 0xff),
>> + .driver_info = RSVD(1) | RSVD(2) | RSVD(3) },
>> { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD100),
>> .driver_info = RSVD(4) },
>> { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD120),
>>
>
> There is only one interface in this device that should be driven by
> optiom, the first interface which likely is a diag interface.
> All other interfaces are driven by CDC drivers and they will not be
> taken by option so no need for the blacklisting of them.
> Remove the .driver_info line from the patch.
>
> thanks
> Lars
prev parent reply other threads:[~2020-11-23 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 11:59 [PATCH] option: added support for Thales Cinterion MV31 option port Giacinto Cifelli
2020-11-20 9:41 ` Johan Hovold
2020-11-23 7:45 ` Giacinto Cifelli
2020-11-23 8:20 ` Lars Melin
2020-11-23 8:33 ` Lars Melin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75d9e32b-416b-d084-9718-7b766e8ce1fc@gmail.com \
--to=larsm17@gmail.com \
--cc=gciofono@gmail.com \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox