From: Joe Perches <joe@perches.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pawel Laszczak <pawell@cadence.com>,
linux-usb@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
pavel.hofman@ivitera.com
Subject: Re: [PATCH][next][V2] usb: gadget: f_uac2: change maxpctksize/maxpcktsize to wMaxPacketSize
Date: Wed, 02 Feb 2022 03:09:11 -0800 [thread overview]
Message-ID: <7719a17b34a22f8375fc0d192141c64952e5549d.camel@perches.com> (raw)
In-Reply-To: <20220202104058.590312-1-colin.i.king@gmail.com>
On Wed, 2022-02-02 at 10:40 +0000, Colin Ian King wrote:
> The spelling of maxpctksize and maxpcktsize is inconsistent, rename them
> both to wMaxPacketSize instead.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> V2: change both strings to wMaxPacketSize
[hmm]
> diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
[]
> @@ -755,11 +755,11 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o
>
> if (max_size_bw <= max_size_ep)
> dev_dbg(dev,
> - "%s %s: Would use maxpctksize %d and bInterval %d\n",
> + "%s %s: Would use wMaxPacketSize %d and bInterval %d\n",
> speed_names[speed], dir, max_size_bw, bint);
> else {
> dev_warn(dev,
> - "%s %s: Req. maxpcktsize %d at bInterval %d > max ISOC %d, may drop data!\n",
> + "%s %s: Req. wMaxPacketSize %d at bInterval %d > max ISOC %d, may drop data!\n",
> speed_names[speed], dir, max_size_bw, bint, max_size_ep);
better still would be to align to the open parenthesis
prev parent reply other threads:[~2022-02-02 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 10:40 [PATCH][next][V2] usb: gadget: f_uac2: change maxpctksize/maxpcktsize to wMaxPacketSize Colin Ian King
2022-02-02 11:09 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7719a17b34a22f8375fc0d192141c64952e5549d.camel@perches.com \
--to=joe@perches.com \
--cc=balbi@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel.hofman@ivitera.com \
--cc=pawell@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox