From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D424AC433EF for ; Thu, 28 Apr 2022 08:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344100AbiD1IaL (ORCPT ); Thu, 28 Apr 2022 04:30:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344104AbiD1IaF (ORCPT ); Thu, 28 Apr 2022 04:30:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 851E9972D6; Thu, 28 Apr 2022 01:26:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B33661F79; Thu, 28 Apr 2022 08:26:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C164FC385A9; Thu, 28 Apr 2022 08:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651134410; bh=GLz5+Ex776cdEP5shJHP4b9TFRJlXnb2hcy3oYy4hds=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HP7W0PIUumKpzOMcgq30IkYm6Q00WTbyKrPa3ogdWwvJDpi/0AfUPBt6ChK2i+3/h OlKFOf2t7EtOOZgNh+WKpUWglb0gCRodOnK8ve6ggm0jlMzZ30IIpmGxrpa010zMnC 6AKytmsPnMiF42Z7wlMD9K9xgV37WxZxoP0KVqQuw+n9oCB9GpDTaTOJQE81lPsHiz 0twvUD4wnCbnjs/FgIJkWDdaZPKc259TzhpLlNMxtMsMVfFgQIHWYYuHddEsBAovTw KYp9TKbRYwP0iE3W7AsmVkxvkR4j8Ske02pDLKpAjFBOJPh/izKhcKQQXrA9/qs4JB RvUAcmtnCvH+g== Message-ID: <786681d7-d079-b8df-c175-ead4099c9549@kernel.org> Date: Thu, 28 Apr 2022 10:26:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 5/5] usb: host: add xhci-exynos driver Content-Language: en-US To: Jung Daehwan Cc: Mathias Nyman , Greg Kroah-Hartman , "open list:USB XHCI DRIVER" , open list , Howard Yen , Jack Pham , Puma Hsu , "J . Avila" , sc.suh@samsung.com, Krzysztof Kozlowski References: <1650964728-175347-1-git-send-email-dh10.jung@samsung.com> <1650964728-175347-6-git-send-email-dh10.jung@samsung.com> <20220428012941.GF145620@ubuntu> <01ec9962-e210-ce47-57cd-8849cca0a9df@kernel.org> <20220428063634.GF151827@ubuntu> <20220428075305.GH151827@ubuntu> From: Krzysztof Kozlowski In-Reply-To: <20220428075305.GH151827@ubuntu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 28/04/2022 09:53, Jung Daehwan wrote: > On Thu, Apr 28, 2022 at 09:31:56AM +0200, Krzysztof Kozlowski wrote: >> On 28/04/2022 08:36, Jung Daehwan wrote: >>>> >>>> Since you called everything here as "exynos" it is specific to one >>>> hardware and not-reusable on anything else. How can then you use some >>>> other compatible? It would be a misuse of Devicetree bindings. >>>> >>> >>> I got it. Let me add them. Is it still necessary if it is only used by >>> other module on runtime as I said above? >> >> Except what Greg wrote, if by "other module" you mean out-of-tree, then >> the patchset will not be accepted as it is unusable for Linux users. >> Basically it would be a dead code in Linux kernel. >> >> Best regards, >> Krzysztof >> > > I wanted to submit patches of just xhci. Let me add a patch together of other > module(dwc3-exynos) that is in-tree on next submission. > > Is it still necessary to add compatible or bindings in this case? The answer depends on: 1. Is it possible to use the code without compatible and bindings? 2. Does the new feature changes the hardware description or hardware behavior? IOW, does it change the meaning of existing bindings? 3. How does it fit to the process explained in bindings/submitting-patches.rst? Best regards, Krzysztof