Re: [PATCH v2 2/3] usb: dwc3: gadget: Add support for snps,reserved-endpoints property

Andy Shevchenko
2025-02-13T08:03:01Z

On Thu, Feb 13, 2025 at 01:16:15AM +0000, Thinh Nguyen wrote:
> On Wed, Feb 12, 2025, Andy Shevchenko wrote:
> > On Wed, Feb 12, 2025 at 01:10:17AM +0000, Thinh Nguyen wrote:
> > > On Mon, Feb 03, 2025, Andy Shevchenko wrote:

...

> > > > /* Reset resource allocation flags */
> > > > - for (i = resource_index; i < dwc->num_eps && dwc->eps[i]; i++)
> > > > - dwc->eps[i]->flags &= ~DWC3_EP_RESOURCE_ALLOCATED;
> > > > + for (i = resource_index; i < dwc->num_eps; i++) {
> > > > + dep = dwc->eps[i];
> > > > + if (!dep)
> > > > + continue;
> > > > +
> > > > + dep->flags &= ~DWC3_EP_RESOURCE_ALLOCATED;
> > > > + }
> > >
> > > Please keep code refactoring as a separate patch.
> >
> > It's induced by the change you asked for, it's not a simple refactoring.
> >
> > Or do you want me to have the patch to check eps against NULL to be separated
> > from this one (see (1) above)?
>
> The condition "i < dwc->num && dwc->eps[i]" already does the NULL check.
> The change here only move things around.

Yes, but the problem is that the loop will stop on the first gap, but we would
like to continue.

> > > > return 0;

--
With Best Regards,
Andy Shevchenko