From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Fan Wu <fanwu01@zju.edu.cn>, linux-usb@vger.kernel.org
Cc: bryan.odonoghue@linaro.org, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop
Date: Thu, 20 Aug 2026 10:17:06 +0200 [thread overview]
Message-ID: <79fa9d60-f8e9-4e5b-8c01-9ddb3a86e3fd@oss.qualcomm.com> (raw)
In-Reply-To: <20260819161448.76597-1-fanwu01@zju.edu.cn>
On 8/19/26 6:14 PM, Fan Wu wrote:
> pdphy_stop() disables IRQs but leaves reset_work pending. If the IRQ
> handler schedules it just before disable_irq(), the work runs after
> remove() frees the struct via devm.
>
> Call cancel_work_sync() after disabling IRQs to close the window.
>
> This issue was found by an in-house static analysis tool.
>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Cc: stable@vger.kernel.org
> Assisted-by: Codex:gpt-5.6
> Signed-off-by: Fan Wu <fanwu01@zju.edu.cn>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-08-20 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 16:14 [PATCH] usb: typec: qcom-pmic: cancel reset_work on stop Fan Wu
2026-08-20 8:17 ` Konrad Dybcio [this message]
2026-08-20 10:15 ` Bryan O'Donoghue
2026-08-24 11:22 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79fa9d60-f8e9-4e5b-8c01-9ddb3a86e3fd@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=bryan.odonoghue@linaro.org \
--cc=fanwu01@zju.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox