From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C4E279C0; Mon, 12 Feb 2024 07:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707724740; cv=none; b=nbQvSDeFPhiMPKTyDdraoygjkcAW7HBkXCVz0gSUVChnA9+RjFhko0RTCAN/9zAcktQJkOddZm3mMyeSy1zWfaxYqWSizn+tWV6HihnmodgDzSu8jgcDrXDfN1L2q+gzg2VRK7PG6zaYoATkAY80K76ovYIFZ9AZGrZ9e+YRGw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707724740; c=relaxed/simple; bh=+4UKT5lMeLqBN6tkRMqWTiLZXcD5qaeXmDujbrzfJ+U=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Ibm/dVaX3qBOmf3BO4u7cVBw8pqxb5AdLijm9ZUD8u5QSNvNqY1JMP5nNAN5mKG3s0hAoPLHlHaUrfQsJsEZzU/H7Zm5nD/Z0LMvWuNeN+hodB67EZtpyRey95mXNQ7ed+FsgWBfxqvTUpm+fZQgJbrxJwEtmnNmj8rKB0cg5Oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Gmewb0m7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Gmewb0m7" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41C5ixuY008599; Mon, 12 Feb 2024 07:58:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=ZSOH1PNXfKcnxMduQOe97NhLQ6gWraBZNi5A2GI1zrg=; b=Gm ewb0m7TnoqQg1weQKx3rmrFinaLGHVngcZ7tVF5oBruuWsoCNKtN1KhjGx/eykG1 9kYeAgZqkDprk/nM+xBiGAgbnwHsDszyWppicxn+M1p1jdCQ0VsnUd9975hR6jXn eSH7atGT45+43Njy6Q/HxiJwg6E7Wl3J/rjGh8EKcBAoFlVEzDZJkRp9F/s7bW8p 4JkaW/Rwtx1iYew/JCu1W4YybxZOcEgYG6iKlScxWgul08LmEIa7REyLjHvq4kIo pf0P5nYKsu1hxAOnuyefGTzWvNN1ziHAMv/4362wNJSeEc5Ub82a/SJRrMTxm6Pf eUEJx14zDcROktVrZvFw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w62n02qqx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Feb 2024 07:58:33 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41C7wWRg005655 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Feb 2024 07:58:32 GMT Received: from [10.110.93.252] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sun, 11 Feb 2024 23:58:31 -0800 Message-ID: <7abc0c1f-c223-c069-7152-418c42aaaecf@quicinc.com> Date: Sun, 11 Feb 2024 23:58:31 -0800 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v14 20/53] ASoC: Add SOC USB APIs for adding an USB backend Content-Language: en-US To: Takashi Iwai CC: , , , , , , , , , , , , , , , , , , , , , References: <20240208231406.27397-1-quic_wcheng@quicinc.com> <20240208231406.27397-21-quic_wcheng@quicinc.com> <87r0hl29ha.wl-tiwai@suse.de> <875xywzqpp.wl-tiwai@suse.de> From: Wesley Cheng In-Reply-To: <875xywzqpp.wl-tiwai@suse.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: W9h0Nhn7smWBWqODCEcxtLDWOGGyIb2g X-Proofpoint-ORIG-GUID: W9h0Nhn7smWBWqODCEcxtLDWOGGyIb2g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-12_05,2024-02-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 mlxlogscore=929 phishscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402120060 Hi Takashi, On 2/10/2024 12:08 AM, Takashi Iwai wrote: > On Fri, 09 Feb 2024 21:34:39 +0100, > Wesley Cheng wrote: >> >> Hi Takashi, >> >> On 2/9/2024 2:54 AM, Takashi Iwai wrote: >>> On Fri, 09 Feb 2024 00:13:33 +0100, >>> Wesley Cheng wrote: >>>> >>>> Some platforms may have support for offloading USB audio devices to a >>>> dedicated audio DSP. Introduce a set of APIs that allow for management of >>>> USB sound card and PCM devices enumerated by the USB SND class driver. >>>> This allows for the ASoC components to be aware of what USB devices are >>>> available for offloading. >>>> >>>> Signed-off-by: Wesley Cheng >>> (snip) >>>> --- a/sound/soc/Makefile >>>> +++ b/sound/soc/Makefile >>>> @@ -1,5 +1,5 @@ >>>> # SPDX-License-Identifier: GPL-2.0 >>>> -snd-soc-core-objs := soc-core.o soc-dapm.o soc-jack.o soc-utils.o soc-dai.o soc-component.o >>>> +snd-soc-core-objs := soc-core.o soc-dapm.o soc-jack.o soc-usb.o soc-utils.o soc-dai.o soc-component.o >>>> snd-soc-core-objs += soc-pcm.o soc-devres.o soc-ops.o soc-link.o soc-card.o >>>> snd-soc-core-$(CONFIG_SND_SOC_COMPRESS) += soc-compress.o >>> >>> Do we really want to build this into ASoC core unconditionally? >>> This is very specific to Qualcomm USB-offload stuff, so it's better to >>> factor out. >>> >> >> Ideally, the SOC USB part shouldn't be Qualcomm specific. Since I >> don't have access or insight into how other vendors are achieving the >> same thing, I can only base the soc-usb layer to work with the >> information that is required to get the audio stream up and running on >> the QC platforms. In its simplest form, its basically just a SW >> entity that notifies ASoC components about changes occurring from USB >> SND, and I think all vendors that have an ASoC based platform card >> handling the offload will need this notification. > > Yes, but it's not necessarily built into the snd-soc-core module at > all, but can be split to another module, right? Otherwise all > machines must load this code even if it doesn't use at all. > If this were common among various chips, it'd be worth to be merged > into the default common module. But I don't think that's the case. > That's fair. I'll make it a separate module and upload v15 tomorrow. Thanks for the explanation. Thanks Wesley Cheng