public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: "Рыжов Фёдор" <symansel@outlook.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] USB: cdc-acm: Add support for second ACM channel on more Nokia phones
Date: Mon, 30 Mar 2026 12:04:04 +0200	[thread overview]
Message-ID: <7ae48e14-0228-4bd9-91df-306dcd12896c@suse.com> (raw)
In-Reply-To: <a8008c91-52c1-4a5c-ac96-dd45f109c68c@outlook.com>

Hi Fyodor,

On 26.03.26 15:37, Рыжов Фёдор wrote:

> This patch extends the whitelist with all S60v3.x and S60v5.x phones,
> supported by official "Nokia PC Suite" driver for Windows. Device IDs
> are taken from its installation configuration file. Older S60v2.x and
> S60v1.x devices were not added because I have no hardware to test.

Thank you for doing this and testing the patch. One nit.
This has two IDs for the same model. This looks like a typo, even
if it is real. Could you add a comment to such entries?

	Regards
		Oliver


  reply	other threads:[~2026-03-30 10:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 14:37 [PATCH] USB: cdc-acm: Add support for second ACM channel on more Nokia phones Рыжов Фёдор
2026-03-30 10:04 ` Oliver Neukum [this message]
2026-04-03 13:20   ` Рыжов Фёдор
2026-04-03 16:06     ` Oliver Neukum
2026-03-30 13:13 ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ae48e14-0228-4bd9-91df-306dcd12896c@suse.com \
    --to=oneukum@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=symansel@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox