From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 059DC156F20 for ; Wed, 4 Feb 2026 13:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770210908; cv=none; b=VnMWSQxDfKs6gx+ynaoeUMq9TWP3YFUrYeFUwJs6OHzuR+donn225AH8wD/P/sh29CEUv5zb2mfMLLqgwRNCf9YFAkkH5Qga0cDsrkzJy9qNz1Cd6VEZgkKmrCQwX9ZYxMoDAJZMecdqzSdPJJ1TszvDG2iWQXnjLHENZpbSc40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770210908; c=relaxed/simple; bh=rHVS6ioRH8ur1X090wZA+nUvR3Xl16eP3aJdGzDLmMo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ehfI93NyE33hZINYgxMzgR0TMv/3xZpWef7Vs1M6a7+vBdUWgHfIiU7H/01+lpO5GyxXKEEazAW2VdbXIuiiU+wCWjBQ07Ym/g2oniQNaB6VXeg7Q7X/SoXhe9t6/w0NWVgtow2e8YpWIhgMNjO+87ELTbtzRVxaYU8QlSGV3X4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j1NWjxcH; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j1NWjxcH" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-81df6a302b1so6395340b3a.2 for ; Wed, 04 Feb 2026 05:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770210907; x=1770815707; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8ftubfnbHJMifavaHfusKulTde0Z2b2i2QG/AKOLuw4=; b=j1NWjxcHhUSEc+qf3+Y4eVOu2LpG2uEOXMoqoPYWjgSQrm18M8v568h+1HAKCo0Yt5 JjmGC2TAORy6cp0LCTUA07jPxxATVo9GYaiM1zM4RwXPkdDNcyyGQ8Qd2hbtOpXgeg/F c9+MaE0TZQ1NxnwFR5RRLyeARR0eFszVpdUl8amZr2FQDWoblu43iWQqPdPWYcFUpiFb Z66Z9l1s0vavIMLCAmAzvBWv6VaiwpZPIq8NuOC90jQg8G2rnLUByXiExcnHjCTBfMXa jZL2DD0u1A1xMdH1FbvULNajhUMc3TQPzaqm4qBe25p8H/sFh3gjXw8x7Sp8PP0uM5vY ee0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770210907; x=1770815707; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8ftubfnbHJMifavaHfusKulTde0Z2b2i2QG/AKOLuw4=; b=lAiB4zSuMjfztoyBrC/U5sRDlgxchrMxCu9p1XEY9bOVGSFDqV1BcGh8/zhNW/Pd7K lHnbbWSKHjIBdrsPZsqWaJHIFpv44pPnEfLRkP7BYlZbiRHBFVlnT8LknuQUYqG99GPO sR1ooBtZVa/sFTQb3NlPH6TIZe+KNmifTSI+M5nwb7tMISdJ0uxTssyQBHhiJYU3GTkO TMdQVffk4qArFqPozNIJ3Kq9v7/lxoTcVI/L+Q9xq++r3PkGSJVozEEdKX6oT+ejI9d2 ZDplxdM7OAWQz2UiIDg1NqMr6SRqvTLKz65fY5KlzAVljCz/LaC/WojgWj9dTaxpBP5X ChDw== X-Gm-Message-State: AOJu0YzOLlnBPq6pzhbyCZGchi/MPnoRZdY4DGNjo8weui43OgBHMObs KtDcknxJ0HkOPLn3FT0yOnCVbkcnnXQvFkBaZwW47WzbQwhxs0phPA2p X-Gm-Gg: AZuq6aKvOEDJSimK15JicIL7O9ytTaIAr3VndfJk+7lKXASXANOQqmQoRrCo9WEeRwG /nHRVdPLAQPqmX6poZdVRiOK6qwlIpQIPaER7m+kDPTDsT+sDGSd5NDG30GJdq7WViJOAGiyAd7 KPKyphYJnGDtSjvhXVSqDjBBpn3sEc+hPHAtUwmk4JvntZ9zkLa0wmNQoVZUG+qhr1hbKFpMg9U W/hKz1c2JNOZjgCUpvhVE0yqxrHT4IzjJ4XfA4TF8R1DTRZBb7RuGS22AA5Ssn3n6b2IvSFQQPj rdbXlZCH0VAvjJfDAHQbDsrPP4iX0Frkef0sw4bjqqZCeVhhi0e9pyQvCHbYJLLx5TFYK24Iog+ tvtkt+0X91oERn3oGn8doD7qt7W0OA4HwwKHvmzt7HPzIgHoyoMx9nYH6pI0AspZCWxh/scvFEa Km45RJLhS27PPK1F35yclmUdvADHKPw3B8Src= X-Received: by 2002:a05:6a20:9396:b0:38b:dec8:9d9a with SMTP id adf61e73a8af0-393724c1cc1mr2968310637.55.1770210906967; Wed, 04 Feb 2026 05:15:06 -0800 (PST) Received: from [192.168.1.7] ([115.99.252.105]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6c8553e888sm2101202a12.31.2026.02.04.05.15.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 05:15:06 -0800 (PST) Message-ID: <7bb66a07-51c5-4e9a-b484-e96a8f12c783@gmail.com> Date: Wed, 4 Feb 2026 18:45:00 +0530 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: usb: atmel,at91rm9200-ohci: convert to DT schema To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Claudiu Beznea , Herve Codina , Nicolas Ferre , Alexandre Belloni Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260201-atmel-usb-v1-0-d1a3e93003f1@gmail.com> <20260201-atmel-usb-v1-1-d1a3e93003f1@gmail.com> Content-Language: en-US From: Charan Pedumuru In-Reply-To: <20260201-atmel-usb-v1-1-d1a3e93003f1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01-02-2026 17:04, Charan Pedumuru wrote: > Convert Atmel AT91RM9200 / AT91SAM9 style OHCI USB Host > Controller binding to DT schema. > Changes during conversion: > - Include "usb-ohci" as a fallback compatible to allow at91 OHCI > driver matching. > > Signed-off-by: Charan Pedumuru > --- > .../bindings/usb/atmel,at91rm9200-ohci.yaml | 85 ++++++++++++++++++++++ > 1 file changed, 85 insertions(+) Hi Rob, For this patch, can I modify the existing generic-ohci.yaml file to include the compatible "atmel,at91rm9200-ohci" to it and define missing properties, as the fall back compatible "usb-ohci" is already defined for other vendors there, can I drop this patch and make changes for generic-ohci.yaml file and include it in the patch series for the next revision? > > diff --git a/Documentation/devicetree/bindings/usb/atmel,at91rm9200-ohci.yaml b/Documentation/devicetree/bindings/usb/atmel,at91rm9200-ohci.yaml > new file mode 100644 > index 000000000000..f04de6d553d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/atmel,at91rm9200-ohci.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/atmel,at91rm9200-ohci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel AT91RM9200 / AT91SAM9 style OHCI USB Host Controller > + > +maintainers: > + - Nicolas Ferre > + - Alexandre Belloni > + > +description: > + The Atmel AT91RM9200 / AT91SAM9 OHCI USB Host Controller implements a > + USB 1.1 Open Host Controller Interface (OHCI) compliant host interface. > + It provides low-speed and full-speed USB host functionality and is > + integrated into Atmel AT91RM9200 and AT91SAM9 family SoCs. > + > +allOf: > + - $ref: /schemas/usb/usb.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: atmel,at91rm9200-ohci > + - const: usb-ohci > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 3 > + maxItems: 3 > + > + clock-names: > + items: > + - const: ohci_clk > + - const: hclk > + - const: uhpck > + > + num-ports: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Number of downstream ports supported by this OHCI controller > + minimum: 1 > + maximum: 15 > + > + atmel,vbus-gpio: > + description: GPIO used to control or sense the USB VBUS power. > + minItems: 1 > + maxItems: 3 > + > + atmel,oc-gpio: > + description: GPIO used to signal USB overcurrent condition. > + minItems: 1 > + maxItems: 3 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + usb@500000 { > + compatible = "atmel,at91rm9200-ohci", "usb-ohci"; > + reg = <0x500000 0x100000>; > + interrupts = <20 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>; > + clock-names = "ohci_clk", "hclk", "uhpck"; > + atmel,vbus-gpio = <&pioA 18 GPIO_ACTIVE_HIGH>; > + atmel,oc-gpio = <&pioB 10 GPIO_ACTIVE_LOW>; > + num-ports = <2>; > + }; > +... > -- Best Regards, Charan.