From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04A4F145B3E for ; Thu, 3 Apr 2025 03:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743651667; cv=none; b=BFlhw3nJjPcL19oUCdchcBdAVOEFyODCJpaQbja7rvc/FZ2tJ8SPiF0PJOnJFcUY4jEpgOC0Q2cFQyClpBYemnblssjqRjtp74Qgb0utVAHLcJkyFZsa/8lMkE+8VhHfn1RK6HyBn4EujRCZJ19brsCUaxAPewpJ3AgWKcrFsEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743651667; c=relaxed/simple; bh=4aTH+S+5/DaE7SK3f14o739lz7d4vHx+nHgg53Ilpic=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qL/zdyPkkmJoLvgFLml4DVwhQpbYu4OmLr6LvAUIesLp/QpMM6BRiUVwbcDkz1whwANukuhxBZ44l/X0rjeRzdKMC8hl+jpDtcydlrQVkFgakP3HBujQSu+9wRJZ8+yjeM8+wtIpTnYuuxRvp2D8kvFUELuhZhXgCInnvzj0N5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lyY9CgLj; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lyY9CgLj" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-227cf12df27so3452445ad.0 for ; Wed, 02 Apr 2025 20:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743651665; x=1744256465; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q0tEj5kz4If7Ej673fi5hk/2hJig3VYxT41dAgyMOLI=; b=lyY9CgLjw5w/omaCCOXRmGOkLC04kzcy2leKTC+7T42kKoJTSdWKzNmOjhxgW3UxzO /97cz3bumayZzjInyeK17jY03f/x4aX3euSUjs0n3saU/BlKKpLEVHdZpIiqIV92Pqx+ zcKezlq1zGycE/WtglYmo6de0b7VO3G5Ec2iIENeXiCptQvvD7/hSZajDdjKem9M+ORD UwdrdCwkPk0tLGrKlTyyB8vRBz3mEQKchMX6EjK3tzKja9nCZNtAz1GlpdiPLcWHjuby NCQxszMh9hmSQiP/677re+qjNIBv5V/KtX+aTnkgLnNmsVejO7FoNzTE2/tTjI3Al5HK Ixiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743651665; x=1744256465; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q0tEj5kz4If7Ej673fi5hk/2hJig3VYxT41dAgyMOLI=; b=tzJTu/aGUuBvfzI4Mm07Pf2QnoRBak7WJrk0+FwMVPRxzKMlxnpSXaLZH71uASXNKo 0H8bWuHM52yP3s4cd6zoyrvUuQW0nsEc3cQHyE3JGLkJ2BKv2lKHLtcR0CVrQPcKmHgC 5oy/Ew0e8iPdgPzFnxr3AYjuRTbrQ7gM6Ag/y94DAclmd9Ze6w54/KKPmTIHuUmF5ZNa 7rn74JKB6jIOCKXGFur4m++fk/h8sv+yPjSJSHPkQ1aXoVgMmFU09HitKVf1mlIO7sWT 0ypNeYNoKs4hcdCsHe9aT5PZyf/aYG2dnZ+C9RkNSjvZk9s88InjLs0bpIGpWelxQyxU bkLA== X-Forwarded-Encrypted: i=1; AJvYcCUxjfhcURrjSirEvd/P/m+W8tZZVJPgEyJ42IrAETbPEP/uzxiank0tOWDwwl2Sx4CAQfPVuFwqFbc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhqw/dBqi5S4q9ev1ekPaIz+92++uDyw0nNV5gx80qL9Qs16uI K5Gk5YR/3w3FwPflj8JUb/zfYLOeVhOo25Ud6uHw3btnQq9jjIHry8e2zpZPGA== X-Gm-Gg: ASbGncvjxdXhoJOMsahDauLqOZJzgZgWZgAdlFzP/GabXErB3F0uM/R70WBC/TnAtEN GHjTO5zf7HePwU4UxzgBbV0ENc8qGSwSm+JvrjQnt47iMX1SwlL2sL+hQmiyZh051FgGL/zqt2S HHGljgVNB/WX+wxogu2GscbC5E+2mQJVeS+/c59BFPXSf1O3xt07zlgPOAOZvwTJOZdDfFgPDZ9 R4DVQdQTG5hjpYuX8nDUvYCmU3cwp7MGbBkdZdidC1QefqjrnpuLL6Gfw2o6gvL6Zm2lahDoI+l twYqGjfgxeSDXMAlrRZc+Lo423XhoJeOqsnUYzd1GH82GrpA1XGhAdccU6kX75djhd1jX2cuU46 ZmCcjcn6Pz3VgT5iLqu3mOPn7FTA1GH8Nx9/ucJTjuJA= X-Google-Smtp-Source: AGHT+IF+aLQLn6pLeab1Mot3xJ/DQBJV5mL7CVD5eHdMlU/bvNw7/84AH4TtA5RPRM1hKWlLyvBvkA== X-Received: by 2002:a17:902:ccca:b0:215:58be:3349 with SMTP id d9443c01a7336-229765ecb95mr30013415ad.14.1743651664993; Wed, 02 Apr 2025 20:41:04 -0700 (PDT) Received: from ?IPV6:2a00:79e0:2e14:7:33af:bd9c:23d7:88c5? ([2a00:79e0:2e14:7:33af:bd9c:23d7:88c5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2297865e483sm3887005ad.116.2025.04.02.20.41.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Apr 2025 20:41:04 -0700 (PDT) Message-ID: <7c7cff17-2c53-4dcd-8760-50c72760de5b@google.com> Date: Wed, 2 Apr 2025 20:41:02 -0700 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] Add support for Battery Status & Battery Caps AMS in TCPM To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Badhri Jagan Sridharan , Sebastian Reichel , Heikki Krogerus , "Rafael J. Wysocki" , Len Brown , Pavel Machek , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, RD Babiera , Kyle Tso References: <20250312-batt_ops-v1-0-88e0bb3129fd@google.com> <20250313-determined-wild-seahorse-f7871a@krzk-bin> <914a0df4-96d0-4cd4-ac87-3826fa9c1440@google.com> <3f65fe16-56f8-4887-bb91-994b181ce5a9@kernel.org> <9852e5a8-843d-48ae-90d0-7991628e93b3@google.com> <442bebf4-4de1-42d1-a14b-2bb509fea12f@kernel.org> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: <442bebf4-4de1-42d1-a14b-2bb509fea12f@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/21/25 12:51 AM, Krzysztof Kozlowski wrote: > On 20/03/2025 22:11, Amit Sunil Dhamne wrote: >> On 3/16/25 9:52 AM, Krzysztof Kozlowski wrote: >>> On 15/03/2025 01:49, Amit Sunil Dhamne wrote: >>>> Hi Krzysztof, >>>> >>>> Thanks for the review! >>>> >>>> On 3/13/25 1:50 AM, Krzysztof Kozlowski wrote: >>>>> On Wed, Mar 12, 2025 at 04:42:00PM -0700, Amit Sunil Dhamne wrote: >>>>>> Support for Battery Status & Battery Caps messages in response to >>>>>> Get_Battery_Status & Get_Battery_Cap request is required by USB PD devices >>>>>> powered by battery, as per "USB PD R3.1 V1.8 Spec", "6.13 Message >>>>>> Applicability" section. This patchset adds support for these AMSes >>>>>> to achieve greater compliance with the spec. >>>>> Which board uses it? I would be happy to see that connection between >>>>> batteries and USB connector on the schematics of some real device. How >>>>> does it look like? >>>> Any board that uses a USB Type-C connector that supplies power into or >>> If you keep responding like this, you will got nowhere, so let me >>> re-iterate: >>> >>> Which upstream DTS (or upstream supported hardware) is going to use this >>> binding, so I can see how you are going to implement it there in the >>> entire system? >> This is for maxim,max33359 Type-C controller. > Stop deflecting the questions. max33359 is not a board. I already asked > two times. > > Apparently admitting "no upstream users" is impossible, so let's state > the obvious: > > There are no upstream users of this. max33359 controller has an upstream user i.e., gs101-oriole (Pixel 6) board. Totally agree that at the moment there are no upstream devices/drivers for the Fuel Gauge (that my patchset has a dependency on) in gs101-oriole board. gs101-oriole uses max77759 fuel gauge device. I see that there's an effort for upstreaming it (https://lore.kernel.org/all/20250102-b4-gs101_max77759_fg-v2-0-87959abeb7ff@uclouvain.be/). I will mark my patches as dependent on it + demonstrate the relationship of the devices in the gs101-oriole board. Hope that's okay? Thanks, Amit >> This would property would have been present for the connector present in >> the typec device for gs101-oriole board (that uses the max33359 >> controller). > > But it is not. > > >> However, I will be exploring existing bindings to describe the >> relationship for now. >> >>>> out of a battery while operating in sink or source mode respectively. >>>> The VBUS is connected to the (battery + buck boost IC's CHGin/Vin) or a >>>> companion IFPMIC connected to a battery.  In our board we have USB >>>> Connector <-> IFPMIC <-> Battery. >>> Which board is that? >> gs101-oriole board. > > Then why this is not used? The board was released some years ago, so I > do not see a problem in using it. > > Best regards, > Krzysztof