From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Joy Chakraborty <joychakr@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Zhihao Cheng <chengzhihao1@huawei.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, linux-media@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-sunxi@lists.linux.dev,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
manugautam@google.com
Subject: Re: [PATCH v1 07/17] misc: eeprom: at25: Change nvmem reg_read/write return type
Date: Fri, 7 Jun 2024 16:36:55 +0100 [thread overview]
Message-ID: <7cc32596-8af0-43ff-91fd-59264d0a29ac@linaro.org> (raw)
In-Reply-To: <f98a1d8f-e936-4798-8447-c642e8fe11d5@moroto.mountain>
On 06/06/2024 09:41, Dan Carpenter wrote:
> So the original bug was that rmem_read() is returning positive values
> on success instead of zero[1]. That started a discussion about partial
> reads which resulted in changing the API to support partial reads[2].
> That patchset broke the build. This patchset is trying to fix the
> build breakage.
>
> [1]https://lore.kernel.org/all/20240206042408.224138-1-joychakr@google.com/
> [2]https://lore.kernel.org/all/20240510082929.3792559-2-joychakr@google.com/
>
> The bug in rmem_read() is still not fixed. That needs to be fixed as
> a stand alone patch. We can discuss re-writing the API separately.
I agree with Dan, Lets fix the rmem_read and start working on the API
rework in parallel.
Am happy to pick the [1].
--srini
next prev parent reply other threads:[~2024-06-07 15:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 17:59 [PATCH v1 00/17] nvmem: Handle change of return type in reg_read/write() definition Joy Chakraborty
2024-06-05 17:59 ` [PATCH v1 01/17] hwmon: pmbus: adm1266: Change nvmem reg_read/write return type Joy Chakraborty
2024-06-05 21:29 ` Guenter Roeck
2024-06-06 9:22 ` Joy Chakraborty
2024-06-06 7:42 ` Dan Carpenter
2024-06-05 17:59 ` [PATCH v1 02/17] media: i2c: ov2740: " Joy Chakraborty
2024-06-05 17:59 ` [PATCH v1 03/17] media: i2c: video-i2c: " Joy Chakraborty
2024-06-05 17:59 ` [PATCH v1 04/17] iio: pressure: bmp280: " Joy Chakraborty
2024-06-05 17:59 ` [PATCH v1 05/17] misc: ds1682: " Joy Chakraborty
2024-06-05 21:18 ` Guenter Roeck
2024-06-06 9:24 ` Joy Chakraborty
2024-06-05 17:59 ` [PATCH v1 06/17] misc: eeprom: at24: " Joy Chakraborty
2024-06-06 10:12 ` Dan Carpenter
2024-06-05 17:59 ` [PATCH v1 07/17] misc: eeprom: at25: " Joy Chakraborty
2024-06-06 8:41 ` Dan Carpenter
2024-06-06 9:42 ` Joy Chakraborty
2024-06-06 10:10 ` Dan Carpenter
2024-06-06 10:31 ` Joy Chakraborty
2024-06-07 15:36 ` Srinivas Kandagatla [this message]
2024-06-05 17:59 ` [PATCH v1 08/17] misc: eeprom: 93xx46: " Joy Chakraborty
2024-06-05 17:59 ` [PATCH v1 09/17] misc: mchp_pci1xxxx: " Joy Chakraborty
2024-06-05 18:12 ` [PATCH v1 00/17] nvmem: Handle change of return type in reg_read/write() definition Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cc32596-8af0-43ff-91fd-59264d0a29ac@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bingbu.cao@intel.com \
--cc=chengzhihao1@huawei.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=joychakr@google.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manugautam@google.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox