* [PATCH v2] Update USB/IP OP_REP_IMPORT documentation.
@ 2024-12-24 6:23 Gordon Ou
2024-12-26 18:28 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Gordon Ou @ 2024-12-24 6:23 UTC (permalink / raw)
To: Valentina Manea, Shuah Khan
Cc: Hongren Zheng, Greg Kroah-Hartman, Jonathan Corbet, linux-usb,
linux-doc, linux-kernel, trivial, Gordon Ou
This is to correct the mistaken byte offset of the field bDeviceClass in
OP_REP_IMPORT documentation. The previous field bcdDevice has length 2 and
the offset for bDeviceClass should be 0x138 + 2 = 0x13A instead of 0x139.
Offsets for subsequent fields are also affected and fixed in this patch.
Signed-off-by: Gordon Ou <gordon.xwj@gmail.com>
---
Changes in v2:
- Updated patch description.
---
Documentation/usb/usbip_protocol.rst | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/usb/usbip_protocol.rst b/Documentation/usb/usbip_protocol.rst
index adc158967cc6..3da1df3d94f5 100644
--- a/Documentation/usb/usbip_protocol.rst
+++ b/Documentation/usb/usbip_protocol.rst
@@ -285,17 +285,17 @@ OP_REP_IMPORT:
+-----------+--------+------------+---------------------------------------------------+
| 0x138 | 2 | | bcdDevice |
+-----------+--------+------------+---------------------------------------------------+
-| 0x139 | 1 | | bDeviceClass |
+| 0x13A | 1 | | bDeviceClass |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13A | 1 | | bDeviceSubClass |
+| 0x13B | 1 | | bDeviceSubClass |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13B | 1 | | bDeviceProtocol |
+| 0x13C | 1 | | bDeviceProtocol |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13C | 1 | | bConfigurationValue |
+| 0x13D | 1 | | bConfigurationValue |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13D | 1 | | bNumConfigurations |
+| 0x13E | 1 | | bNumConfigurations |
+-----------+--------+------------+---------------------------------------------------+
-| 0x13E | 1 | | bNumInterfaces |
+| 0x13F | 1 | | bNumInterfaces |
+-----------+--------+------------+---------------------------------------------------+
The following four commands have a common basic header called
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Update USB/IP OP_REP_IMPORT documentation.
2024-12-24 6:23 [PATCH v2] Update USB/IP OP_REP_IMPORT documentation Gordon Ou
@ 2024-12-26 18:28 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2024-12-26 18:28 UTC (permalink / raw)
To: Gordon Ou, Valentina Manea, Shuah Khan
Cc: Hongren Zheng, Greg Kroah-Hartman, Jonathan Corbet, linux-usb,
linux-doc, linux-kernel, trivial, Shuah Khan
On 12/23/24 23:23, Gordon Ou wrote:
> This is to correct the mistaken byte offset of the field bDeviceClass in
> OP_REP_IMPORT documentation. The previous field bcdDevice has length 2 and
> the offset for bDeviceClass should be 0x138 + 2 = 0x13A instead of 0x139.
> Offsets for subsequent fields are also affected and fixed in this patch.
>
> Signed-off-by: Gordon Ou <gordon.xwj@gmail.com>
> ---
> Changes in v2:
> - Updated patch description.
Looks good to me.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Greg, please pick this up.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-26 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-24 6:23 [PATCH v2] Update USB/IP OP_REP_IMPORT documentation Gordon Ou
2024-12-26 18:28 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).