From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Niklas Neronin <niklas.neronin@linux.intel.com>
Subject: Re: [PATCH] usb: xhci: Fix HCS_ERST_MAX conversion
Date: Thu, 20 Aug 2026 15:34:21 +0300 [thread overview]
Message-ID: <7e6648ad-7459-4248-8c6c-227cfc2586d8@linux.intel.com> (raw)
In-Reply-To: <20260820095714.1865096-1-wenst@chromium.org>
On 8/20/26 12:57, Chen-Yu Tsai wrote:
> This partially reverts commit 6d45e9556d4a11b726e897d86e095b96db4550d8.
>
> HCS_ERST_MAX holds power of 2 value for maximum number of segments.
> In the culprit commit, this was incorrectly converted to "shift up 2".
> On hardware where this field is zero, this results in xhci_alloc_erst()
> calling dma_alloc_coherent() with size = 0, leading to a horrible splat
> and non-usable XHCI.
>
> Revert the shift-up-2 to the BIT() macro.
>
> Fixes: 6d45e9556d4a ("usb: xhci: standardize multi bit-field macros")
> Cc: Niklas Neronin <niklas.neronin@linux.intel.com>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
Thanks
Adding to queue, will submit after rc1
-Mathias
prev parent reply other threads:[~2026-08-20 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 9:57 [PATCH] usb: xhci: Fix HCS_ERST_MAX conversion Chen-Yu Tsai
2026-08-20 12:34 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e6648ad-7459-4248-8c6c-227cfc2586d8@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=niklas.neronin@linux.intel.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox