From: Roman Gushchin <roman.gushchin@linux.dev>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: Thoughts on Sashiko reviews for linux-usb
Date: Tue, 06 Oct 2026 05:51:20 +0000 [thread overview]
Message-ID: <7ia4ld8b8jhj.fsf@castle.c.googlers.com> (raw)
In-Reply-To: <2026100602-overtly-scaling-3153@gregkh> (Greg Kroah-Hartman's message of "Tue, 6 Oct 2026 07:41:43 +0200")
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Tue, Oct 06, 2026 at 07:03:14AM +0200, Greg Kroah-Hartman wrote:
>> On Tue, Oct 06, 2026 at 12:45:15AM +0000, Thinh Nguyen wrote:
>> > Hi all,
>> >
>> > I'd like to get your thoughts on having Sashiko send review results to
>> > linux-usb for patches posted to the list.
>> >
>> > I started looking into this after receiving a reference to a Sashiko
>> > review for a dwc3 patch that I wasn't Cc'd on, which required me to
>> > track down the review separately to understand the feedback.
>> >
>> > Sashiko is currently configured per mailing list, so any change would
>> > apply to all patches sent to linux-usb rather than a specific subsystem.
>> >
>> > Would anyone object to enabling Sashiko reviews on linux-usb?
>>
>> Not at all, want to submit the pull request to the repo to add it, or do
>> you need/want me to?
>
> Now done:
> https://github.com/sashiko-dev/sashiko/pull/651
> but I don't know if that adds a "will email back the review" workflow
> for patches sent to linux-usb@vger.
>
> Roman, it looks like the sashiko.dev/email_policy.toml file isn't in the
> repo anymore, or at least it's not in the git checkout that I can see.
> Does the linux-usb list need to be configured anywhere else as well?
I moved it to deployment/sashiko.dev/email_policy.toml while preparing
to support other projects.
You need to define the email policy to receive reviews over the email.
I can help with that, just let me know who it should to/cc?
It seems that the most popular option is to reply to the author and cc
the mailing list.
Your PR is merged, thanks!
next prev parent reply other threads:[~2026-10-06 5:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 0:45 Thoughts on Sashiko reviews for linux-usb Thinh Nguyen
2026-10-06 1:43 ` Alan Stern
2026-10-06 5:03 ` Greg Kroah-Hartman
2026-10-06 5:41 ` Greg Kroah-Hartman
2026-10-06 5:51 ` Roman Gushchin [this message]
2026-10-06 6:01 ` Greg Kroah-Hartman
2026-10-06 6:05 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ia4ld8b8jhj.fsf@castle.c.googlers.com \
--to=roman.gushchin@linux.dev \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox