From: Joe Perches <joe@perches.com>
To: Tom Rix <trix@redhat.com>,
balbi@kernel.org, gregkh@linuxfoundation.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
waynec@nvidia.com, rikard.falkeborn@gmail.com,
zhangqilong3@huawei.com, jakobkoschel@gmail.com
Cc: linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: tegra-xudc: clean up comments
Date: Sat, 16 Apr 2022 17:36:17 -0700 [thread overview]
Message-ID: <817a2890f5483e9a4b51ff6cc3eaab966e4f0537.camel@perches.com> (raw)
In-Reply-To: <20220416223921.2881719-1-trix@redhat.com>
On Sat, 2022-04-16 at 18:39 -0400, Tom Rix wrote:
> Spelling replacements
> cancelled to canceled
cancelled is a generally accepted variant.
https://www.dictionary.com/browse/cancelled
> endpiont to endpoint
ok.
> Compliance to Compliance
huh? a == a
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
> index d9c406bdb680..0aaf01e1551f 100644
> --- a/drivers/usb/gadget/udc/tegra-xudc.c
> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
> @@ -1330,7 +1330,7 @@ static void squeeze_transfer_ring(struct tegra_xudc_ep *ep,
> bool pcs;
>
> /*
> - * Clear out all the TRBs part of or after the cancelled request,
> + * Clear out all the TRBs part of or after the canceled request,
> * and must correct trb cycle bit to the last un-enqueued state.
> */
> while (trb != &ep->transfer_ring[ep->enq_ptr]) {
> @@ -1343,11 +1343,11 @@ static void squeeze_transfer_ring(struct tegra_xudc_ep *ep,
> trb = ep->transfer_ring;
> }
>
> - /* Requests will be re-queued at the start of the cancelled request. */
> + /* Requests will be re-queued at the start of the canceled request. */
> ep->enq_ptr = req->first_trb - ep->transfer_ring;
> /*
> * Retrieve the correct cycle bit state from the first trb of
> - * the cancelled request.
> + * the canceled request.
> */
> ep->pcs = pcs_enq;
> ep->ring_full = false;
> @@ -1434,7 +1434,7 @@ __tegra_xudc_ep_dequeue(struct tegra_xudc_ep *ep,
> return 0;
> }
>
> - /* Halt DMA for this endpiont. */
> + /* Halt DMA for this endpoint. */
> if (ep_ctx_read_state(ep->context) == EP_STATE_RUNNING) {
> ep_pause(xudc, ep->index);
> ep_wait_for_inactive(xudc, ep->index);
> @@ -3423,7 +3423,7 @@ static void tegra_xudc_device_params_init(struct tegra_xudc *xudc)
> }
>
> /*
> - * Compliacne suite appears to be violating polling LFPS tBurst max
> + * Compliance suite appears to be violating polling LFPS tBurst max
> * of 1.4us. Send 1.45us instead.
> */
> val = xudc_readl(xudc, SSPX_CORE_CNT32);
next prev parent reply other threads:[~2022-04-17 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 22:39 [PATCH] usb: gadget: tegra-xudc: clean up comments Tom Rix
2022-04-17 0:36 ` Joe Perches [this message]
2022-04-17 12:57 ` Tom Rix
2022-04-17 17:45 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=817a2890f5483e9a4b51ff6cc3eaab966e4f0537.camel@perches.com \
--to=joe@perches.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jakobkoschel@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=trix@redhat.com \
--cc=waynec@nvidia.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox