From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m1973186.qiye.163.com (mail-m1973186.qiye.163.com [220.197.31.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3BC61400E; Tue, 23 Sep 2025 09:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.86 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758619410; cv=none; b=D5oSKwht8WwyKMlwrilPgSx4mpy7gsD+MdQ5gKdGorgNseB42IN7tfSl3WFF0Ig3xO7EMT4k1H20Hfav5tkLeg4Zc6QrrD+6k6T9qO0tX6vcnxgQlyUwwtjilA7j+A8/0HXiK+GM4myFdJWgIy9jkPITHG3Ra3Y1Ls48gwd8mak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758619410; c=relaxed/simple; bh=YsIYnVzfSPxpVvjt/XAKbJoZbnK0hdwHhRGcmpD5Jhc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WFmMQRk/7NSUx8g5+bKBT/ag68T1i/qliMxdFzEZm2PV3TWTszPzhYiFzQgYhAyKSSJlWf9mjSoH5uzJam6vFBwXDMmTGlw8XF80gfVWXZN8NWNdI++5WgIzToZosM1T+tokOAZa43EyrhJSQSsr1sjbnwq/HyjhsK9mNz6Ny8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=cbNY1QVT; arc=none smtp.client-ip=220.197.31.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="cbNY1QVT" Received: from [172.16.12.153] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 23b9177a0; Tue, 23 Sep 2025 11:40:35 +0800 (GMT+08:00) Message-ID: <8396dd15-9111-4ceb-a561-6ed57727546f@rock-chips.com> Date: Tue, 23 Sep 2025 11:40:33 +0800 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/7] dt-bindings: phy: rockchip: rk3399-typec-phy: Support mode-switch To: Dmitry Baryshkov Cc: Chaoyi Chen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Heikki Krogerus , Greg Kroah-Hartman , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org References: <20250922012039.323-1-kernel@airkyi.com> <20250922012039.323-3-kernel@airkyi.com> <533d41bd-9293-4808-85f3-8fb6dc8bcda7@rock-chips.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9974a8abd103abkunm3cf890a4eb55b X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQ09KH1YfSxoZGkwYThkZS0hWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpPSE xVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=cbNY1QVTq4ppl4jyOwF7tumwsvMIakcT3973cK6igiHD2I6Z1e6IdCjrWZtY5ojzKbDSYrp6+0OhklB+Z3gE5YRglgYHRYu9quejf9cfFM4iRQLujzUflTJ5byBxV+O07/oRwbu+7WqoenxLpysHAwH8PRjtVPn5yL+zs82jpdw=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=4KUKqQ7mqQ2zVDBXjqLvwFYHz4+0xl7oABzJGnrMKc8=; h=date:mime-version:subject:message-id:from; On 9/23/2025 11:17 AM, Dmitry Baryshkov wrote: > On Tue, Sep 23, 2025 at 09:53:06AM +0800, Chaoyi Chen wrote: >> Hi Dmitry, >> >> On 9/23/2025 9:12 AM, Dmitry Baryshkov wrote: >>> On Mon, Sep 22, 2025 at 09:20:34AM +0800, Chaoyi Chen wrote: >>>> From: Chaoyi Chen >>>> >>>> The RK3399 SoC integrates two USB/DP combo PHYs, each of which >>>> supports software-configurable pin mapping and DisplayPort lane >>>> assignment. These capabilities enable the PHY itself to handle both >>>> mode switching and orientation switching, based on the Type-C plug >>>> orientation and USB PD negotiation results. >>>> >>>> While an external Type-C controller is still required to detect cable >>>> attachment and report USB PD events, the actual mode and orientation >>>> switching is performed internally by the PHY through software >>>> configuration. This allows the PHY to act as a Type-C multiplexer for >>>> both data role and DP altmode configuration. >>>> >>>> To reflect this hardware design, this patch introduces a new >>>> "mode-switch" property for the dp-port node in the device tree bindings. >>>> This property indicates that the connected PHY is capable of handling >>>> Type-C mode switching itself. >>>> >>>> Signed-off-by: Chaoyi Chen >>>> >>>> Acked-by: Krzysztof Kozlowski >>>> --- >>>> >>>> Changes in v4: >>>> - Remove "|" in description. >>>> >>>> Changes in v3: >>>> - Add more descriptions to clarify the role of the PHY in switching. >>>> >>>> Changes in v2: >>>> - Reuse dp-port/usb3-port in rk3399-typec-phy binding. >>>> >>>> .../devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml >>>> index 91c011f68cd0..83ebcde096ea 100644 >>>> --- a/Documentation/devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml >>>> +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3399-typec-phy.yaml >>>> @@ -51,6 +51,12 @@ properties: >>>> '#phy-cells': >>>> const: 0 >>>> + mode-switch: >>> Having the mode-switch here is a bit strange. I think the whole PHY >>> device should be an orientation-switch and mode-switch. Otherwise it >>> feels weird to me. >> I think this is a difference in practice. In the previous binding, there was already an orientation-switch under the usb-port. I trying to add both an orientation-switch and a mode-switch to the top-level device in v2. And Krzysztof reminded me that adding a mode-switch under the dp-port would be better, so I changed it to the current form :) > I couldn't find the comment on lore. Could you please point it out? Sorry, it is v1. I added an orientation-switch and a mode-switch in the top-level PHY [0]. Comment is here: [1] [0] https://lore.kernel.org/all/20250715112456.101-4-kernel@airkyi.com/ [1] https://lore.kernel.org/all/4dfed94c-665d-4e04-b527-ddd34fd3db8f@kernel.org/ >> >> >>>> + description: >>>> + Indicates the PHY can handle altmode switching. In this case, >>>> + requires an external USB Type-C controller to report USB PD message. >>>> + type: boolean >>>> + >>>> port: >>>> $ref: /schemas/graph.yaml#/properties/port >>>> description: Connection to USB Type-C connector >>>> -- >>>> 2.49.0 >>>> >> -- >> Best, >> Chaoyi >> -- Best, Chaoyi