Re: [PATCH] unbreak all modern Seagate ATA pass-through for SMART

René Rebe
2021-04-25T07:21:40Z

Hey,

> On 25. Apr 2021, at 04:31, Alan Stern <stern@rowland.harvard.edu> wrote:
>> Seagate devices" in 2017. Apparently some early ones where buggy, ...
>>
>> However, fast forward a couple of years and this is no longer true,
>> this Segate Seven even is already from 2016, and apparently first
>> available in 2015. I suggest removing this rather drastic global
>> measure, and instead only add very old broken ones with individual
>> quirks, should any of them still be alive ;-)
>>
>> Signed-off-by: René Rebe <rene@exactcode.com>
>>
>> --- linux-5.11/drivers/usb/storage/uas-detect.h.backup 2021-03-05 11:36:00.517423726 +0100
>> +++ linux-5.11/drivers/usb/storage/uas-detect.h 2021-03-05 11:36:16.373424544 +0100
>> @@ -113,8 +113,4 @@
>> }
>>
>> - /* All Seagate disk enclosures have broken ATA pass-through support */
>> - if (le16_to_cpu(udev->descriptor.idVendor) == 0x0bc2)
>> - flags |= US_FL_NO_ATA_1X;
>> -
>> usb_stor_adjust_quirks(udev, &flags);
>
> I don't want to do this unless you can suggest an approach that won't
> suddenly break all those old buggy drives. Just because they are now
> five years old or more doesn't mean they are no longer in use.

Well, what do you propose then? A allow quirk for all new devices going forward?
Given that the user usually needs to actively run something like smartctl
manually on the drive I don’t see that this should cause too many issues.
I don’t have any non-supporting device - can we not just add them to the
quirk list when someone reports one?

> Alan Stern
>
> PS: As a matter of good form, you should have CC'ed the person whose
> commit you are proposing to revert.

Thanks, forgot to paste them ;-)

René

--
ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin, https://exactcode.com
https://exactscan.com | https://ocrkit.com | https://t2sde.org | https://rene.rebe.de