Linux USB
 help / color / mirror / Atom feed
From: claus.stovgaard@gmail.com
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"v.anuragkumar@gmail.com" <v.anuragkumar@gmail.com>,
	Rob Weber <rob@gnarbox.com>
Subject: Re: Clarification of set_sel handling when dwc3 is a device (gadget)
Date: Wed, 03 Jul 2019 22:34:16 +0200	[thread overview]
Message-ID: <847524769f1229b1a96d5ccea53c999497dccfff.camel@gmail.com> (raw)
In-Reply-To: <CY4PR1201MB0037D801D920ACAD8B4CF3B6AAF90@CY4PR1201MB0037.namprd12.prod.outlook.com>

On man, 2019-07-01 at 20:48 +0000, Thinh Nguyen wrote:
> Hi,
> 
> 

> > ----
> > reg = dwc3_readl(dwc->regs, DWC3_DCTL);
> > if (reg & DWC3_DCTL_INITU2ENA)
> > 	param = dwc->u2pel;
> > if (reg & DWC3_DCTL_INITU1ENA)
> > 	param = dwc->u1pel;
> 
> This is incorrect. If the controller is enabled for both U1 and U2,
> then
> periodic param is U2PEL. If the controller is only enabled for U1,
> then
> U1PEL is used. Probably the original author intended but missed the
> "else" on the second if case.
> 
> 
> According to the databook, currently the controller doesn't use these
> programmed values. It uses the value from CoreConsultant
> configuration
> setting.
> 

Thanks for your quick reply.

So my understanding from your message is that the code is wrong, and I
was correct in being puzzled. Though the core currently does not use
the values, so currently the code is unimportant as it is unused by the
hardware.

Regards
Claus


> BR,
> Thinh


  reply	other threads:[~2019-07-03 20:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-29 20:26 Clarification of set_sel handling when dwc3 is a device (gadget) claus.stovgaard
2019-07-01 20:48 ` Thinh Nguyen
2019-07-03 20:34   ` claus.stovgaard [this message]
2019-07-03 21:12     ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=847524769f1229b1a96d5ccea53c999497dccfff.camel@gmail.com \
    --to=claus.stovgaard@gmail.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rob@gnarbox.com \
    --cc=v.anuragkumar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox