From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBA6C433EF for ; Thu, 20 Jan 2022 10:32:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376312AbiATKcx (ORCPT ); Thu, 20 Jan 2022 05:32:53 -0500 Received: from guitar.tcltek.co.il ([84.110.109.230]:55517 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1359851AbiATKcx (ORCPT ); Thu, 20 Jan 2022 05:32:53 -0500 Received: from tarshish (unknown [10.0.8.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id A83A7440EC4; Thu, 20 Jan 2022 12:32:41 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1642674762; bh=vLMmNW2zYd4cs+GrkWWq8UgDVQ4AcyicuNf3Ub6yOBM=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=PJf4vnRUn6ZMWWDokawzeHfIXZb+pppxcGRJUNB62fmaSCRCX1CIDwvyWLchN9dcS ksNv22a841TrpPPvuXRhs33vKx/wGpP2FcVXCh2H23lq2D7cm4ekodRlbHLM0s4yTq w4dyVJO2mveUsYlfzvcdJmT+HFsA+IESJTzoTG/vijQQqu0cUkcFoKyX3t43p0vgnR feBJMrb6PkY+rxk7evREegEIXqaDZtBn+zOFns93Xfi0sjklWOvMNaD9oa9/OkQmte 52PgdUQkfhMVQ+vPQuIsztHuTzwSPlG5U+bW9ExUdkO8aRuJh23kDqzx+31wzz0JfK AdCw9SLMbl//g== References: <20220119002438.106079-1-sean.anderson@seco.com> <87ee53fv01.fsf@tarshish> <1965fc315525b8ab26cf9f71f939c24d@codeaurora.org> User-agent: mu4e 1.6.10; emacs 27.1 From: Baruch Siach To: Kathiravan T Cc: Sean Anderson , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Felipe Balbi , Thinh Nguyen , Balaji Prakash J , linux-kernel@vger.kernel.org, Robert Hancock , Andy Gross , Bjorn Andersson , Michal Simek , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Date: Thu, 20 Jan 2022 12:29:32 +0200 In-reply-to: <1965fc315525b8ab26cf9f71f939c24d@codeaurora.org> Message-ID: <871r12g0j2.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Kathiravan, On Thu, Jan 20 2022, Kathiravan T wrote: > On 2022-01-19 23:44, Baruch Siach wrote: >> Hi Sean, >> On Tue, Jan 18 2022, Sean Anderson wrote: >>> This is a rework of patches 3-5 of [1]. It attempts to correctly program >>> REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since >>> we no longer need a special property duplicating this configuration, >>> snps,ref-clock-period-ns is deprecated. >>> Please test this! Patches 3/4 in this series have the effect of >>> programming REFCLKPER and REFCLK_FLADJ on boards which already configure >>> the "ref" clock. I have build tested, but not much else. >> Tested here on IPQ6010 based system. USB still works. But the with >> "ref" >> clock at 24MHz, period is calculated as 0x29. Previous >> snps,ref-clock-period-ns value used to be 0x32. >> Is that expected? > > Yes, it is 0x29 for IPQ60xx based SoCs. In downstream it was wrongly mentioned > as 0x32, which was corrected recently. Thanks for the update. This needs fixing in upstream kernel. I'll send a patch. For some reason USB appears to work here with both values. Is it because I only use USB2 signals? If this is the case them I can not actually test this series on my system. Thanks, baruch >>> [1] >>> https://lore.kernel.org/linux-usb/20220114044230.2677283-1-robert.hancock@calian.com/ >>> Changes in v2: >>> - Document clock members >>> - Also program GFLADJ.240MHZDECR >>> - Don't program GFLADJ if the version is < 2.50a >>> - Add snps,ref-clock-frequency-hz property for ACPI >>> Sean Anderson (7): >>> dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns >>> usb: dwc3: Get clocks individually >>> usb: dwc3: Calculate REFCLKPER based on reference clock >>> usb: dwc3: Program GFLADJ >>> usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI >>> arm64: dts: zynqmp: Move USB clocks to dwc3 node >>> arm64: dts: ipq6018: Use reference clock to set dwc3 period >>> .../devicetree/bindings/usb/snps,dwc3.yaml | 7 +- >>> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 3 +- >>> .../arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 4 +- >>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 +- >>> drivers/usb/dwc3/core.c | 112 +++++++++++++++--- >>> drivers/usb/dwc3/core.h | 17 ++- >>> 6 files changed, 120 insertions(+), 27 deletions(-) -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -