From: Felipe Balbi <balbi@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>,
gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] usb: dwc3: enable runtime PM for drd role switch / extcon
Date: Mon, 16 Mar 2020 09:22:23 +0200 [thread overview]
Message-ID: <8736a8228g.fsf@kernel.org> (raw)
In-Reply-To: <ab538c6e-b524-d690-984b-126651cf4d4d@puri.sm>
[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]
Hi,
Martin Kepplinger <martin.kepplinger@puri.sm> writes:
>> (for commit logs, please break your lines at 72 characters)
>>
>> Martin Kepplinger <martin.kepplinger@puri.sm> writes:
>>
>>> Note: runtime PM currently needs to be enabled ("auto") manually via
>>> sysfs as its power/control is set to "on" by the driver.
>>
>> Right, that's on purpose
>>
>>> When runtime PM enabled, dwc3 currently doesn't resume when a cable is
>>> connected. It only suspends after a cable is disconnected.
>>>
>>> When using an extcon driver (for a different chip on the board), dwc3
>>> can register a hook for that. (Still undocumented -> TODO?).
>>>
>>> Make sure, dwc3 is resumed when "set_mode" is being called by drd.
>>>
>>> this is only a question about what's missing to properly keep runtime
>>> PM enabled for dwc3 and if my change makes any sense at all. It seems
>>> to work fine for me...
>>>
>>> I'm glad about any hints on how to keep runtime PM enabled (at least when
>>> having an extcon hook set up).
>>
>> You need to remember that what you write here is going to be placed in
>> the commit log and will survive forever in the history of the
>> project. Can you be a little bit more technical? For example, why did
>> you change the asynchronous pm_runtime_put() to synchronous versions?
>> Why was that necessary?>
>> Also, you're missing your Signed-off-by line. Please, read the
>> documentation about how to write patches.
>
> I don't sign off on this change. It merely servers as a basis for the
> question I have: How to properly have continuous runtime PM in dwc3 (at
> least when having an extcon device connected) and is there any specific
> reason why this isn't yet implemented?
Probably because nobody has spent the time to do it. If you have HW and
time to implement this, by all means, go ahead.
Just make sure to keep the current functionality: pm runtime should only
be enabled by userspace.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-03-16 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 14:30 [RFC PATCH] usb: dwc3: enable runtime PM for drd role switch / extcon Martin Kepplinger
2020-03-15 9:13 ` Felipe Balbi
2020-03-16 7:18 ` Martin Kepplinger
2020-03-16 7:22 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736a8228g.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).