Re: [PATCH] usb: dwc3: trace: Print register read and write offset

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]


Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> Currently dwc3 only prints the virtual address of a register when doing
> register read/write. However, these hashed addresses are difficult to read.
> Also, since we use %p, we may get some useless (___ptrval___) prints if the
> address is not randomized enough. Let's include the register offset to help
> read the register read and write tracepoints.
>
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> ---
>  drivers/usb/dwc3/trace.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h
> index 97f4f1125a41..3cbeb9854532 100644
> --- a/drivers/usb/dwc3/trace.h
> +++ b/drivers/usb/dwc3/trace.h
> @@ -32,8 +32,10 @@ DECLARE_EVENT_CLASS(dwc3_log_io,
>  		__entry->offset = offset;
>  		__entry->value = value;
>  	),
> -	TP_printk("addr %p value %08x", __entry->base + __entry->offset,
> -			__entry->value)
> +	TP_printk("addr %p offset %04x value %08x",
> +		__entry->base + __entry->offset,
> +		__entry->offset,

might be better, then, to print base and offset separately. Other than
that:

Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]