From: Felipe Balbi <balbi@kernel.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com, pawell@cadence.com,
rogerq@ti.com, gregkh@linuxfoundation.org, jun.li@nxp.com,
Peter Chen <peter.chen@nxp.com>
Subject: Re: [PATCH 7/8] usb: cdns3: gadget: sg_support is only for DEV_VER_V2 or above
Date: Tue, 08 Sep 2020 09:30:59 +0300 [thread overview]
Message-ID: <874ko8n5jw.fsf@kernel.org> (raw)
In-Reply-To: <20200901084454.28649-8-peter.chen@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]
Peter Chen <peter.chen@nxp.com> writes:
> The scatter buffer list support earlier than DEV_VER_V2 is not
> good enough, software can't know well about short transfer for it.
>
> Cc: Pawel Laszczak <pawell@cadence.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/usb/cdns3/gadget.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 1fd36bc5c6db..82dc362550bf 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -3161,7 +3161,6 @@ static int cdns3_gadget_start(struct cdns3 *cdns)
> priv_dev->gadget.speed = USB_SPEED_UNKNOWN;
> priv_dev->gadget.ops = &cdns3_gadget_ops;
> priv_dev->gadget.name = "usb-ss-gadget";
> - priv_dev->gadget.sg_supported = 1;
> priv_dev->gadget.quirk_avoids_skb_reserve = 1;
> priv_dev->gadget.irq = cdns->dev_irq;
>
> @@ -3200,6 +3199,8 @@ static int cdns3_gadget_start(struct cdns3 *cdns)
> readl(&priv_dev->regs->usb_cap2));
>
> priv_dev->dev_ver = GET_DEV_BASE_VERSION(priv_dev->dev_ver);
> + if (priv_dev->dev_ver >= DEV_VER_V2)
> + priv_dev->gadget.sg_supported = 1;
is this a bug fix?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2020-09-08 6:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 8:44 [PATCH 0/8] usb: cdns3: improve the sg use case Peter Chen
2020-09-01 8:44 ` [PATCH 1/8] usb: cdns3: gadget: using correct sg operations Peter Chen
2020-09-08 6:19 ` Felipe Balbi
2020-09-08 7:11 ` Peter Chen
2020-09-01 8:44 ` [PATCH 2/8] usb: cdns3: gadget: improve the dump TRB operation at cdns3_ep_run_transfer Peter Chen
2020-09-08 6:19 ` Felipe Balbi
2020-09-08 7:11 ` Peter Chen
2020-09-01 8:44 ` [PATCH 3/8] usb: cdns3: gadget: calculate TDL correctly Peter Chen
2020-09-08 6:21 ` Felipe Balbi
2020-09-08 7:15 ` Peter Chen
2020-09-01 8:44 ` [PATCH 4/8] usb: cdns3: gadget: add CHAIN and ISP bit for sg list use case Peter Chen
2020-09-08 6:22 ` Felipe Balbi
2020-09-08 7:21 ` Peter Chen
2020-09-08 7:43 ` Felipe Balbi
2020-09-01 8:44 ` [PATCH 5/8] usb: cdns3: gadget: handle sg list use case at completion correctly Peter Chen
2020-09-08 6:25 ` Felipe Balbi
2020-09-08 8:34 ` Peter Chen
2020-09-10 8:37 ` Peter Chen
2020-09-01 8:44 ` [PATCH 6/8] usb: cdns3: gadget: need to handle sg case for WA2 case Peter Chen
2020-09-08 6:29 ` Felipe Balbi
2020-09-08 9:07 ` Peter Chen
2020-09-01 8:44 ` [PATCH 7/8] usb: cdns3: gadget: sg_support is only for DEV_VER_V2 or above Peter Chen
2020-09-08 6:30 ` Felipe Balbi [this message]
2020-09-08 9:08 ` Peter Chen
2020-09-01 8:44 ` [PATCH 8/8] usb: cdns3: gadget: enlarge the TRB ring length Peter Chen
2020-09-08 6:32 ` Felipe Balbi
2020-09-08 9:18 ` Peter Chen
2020-09-08 9:30 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ko8n5jw.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).