* [v1,4/5] usb: dwc3: drd: Switch to device property for 'extcon' handling
@ 2018-11-10 18:11 Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2018-11-10 18:11 UTC (permalink / raw)
To: MyungJoo Ham, Chanwoo Choi, linux-usb, Felipe Balbi,
Guenter Roeck, Heikki Krogerus, Roger Quadros, linux-pm,
Rafael J. Wysocki, Sebastian Reichel, linux-omap, Darren Hart,
platform-driver-x86, Greg Kroah-Hartman, linux-kernel,
Chen-Yu Tsai, Hans de Goede
Cc: Andy Shevchenko
Switch to device property for 'extcon' handling.
No functional change intended.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/usb/dwc3/drd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index e7e421521a34..5dc4cddd5b68 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -10,6 +10,7 @@
#include <linux/extcon.h>
#include <linux/of_graph.h>
#include <linux/platform_device.h>
+#include <linux/property.h>
#include "debug.h"
#include "core.h"
@@ -485,8 +486,8 @@ static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
struct device_node *np_phy, *np_conn;
struct extcon_dev *edev;
- if (of_property_read_bool(dev->of_node, "extcon"))
- return extcon_get_edev_by_phandle(dwc->dev, 0);
+ if (device_property_read_bool(dev, "extcon"))
+ return extcon_get_edev_by_phandle(dev, 0);
np_phy = of_parse_phandle(dev->of_node, "phys", 0);
np_conn = of_graph_get_remote_node(np_phy, -1, -1);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [v1,4/5] usb: dwc3: drd: Switch to device property for 'extcon' handling
@ 2018-11-12 11:47 Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2018-11-12 11:47 UTC (permalink / raw)
To: Andy Shevchenko, MyungJoo Ham, Chanwoo Choi, linux-usb,
Guenter Roeck, Heikki Krogerus, Roger Quadros, linux-pm,
Rafael J. Wysocki, Sebastian Reichel, linux-omap, Darren Hart,
platform-driver-x86, Greg Kroah-Hartman, linux-kernel,
Chen-Yu Tsai, Hans de Goede
Hi,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> Switch to device property for 'extcon' handling.
> No functional change intended.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/usb/dwc3/drd.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
> index e7e421521a34..5dc4cddd5b68 100644
> --- a/drivers/usb/dwc3/drd.c
> +++ b/drivers/usb/dwc3/drd.c
> @@ -10,6 +10,7 @@
> #include <linux/extcon.h>
> #include <linux/of_graph.h>
> #include <linux/platform_device.h>
> +#include <linux/property.h>
>
> #include "debug.h"
> #include "core.h"
> @@ -485,8 +486,8 @@ static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
> struct device_node *np_phy, *np_conn;
> struct extcon_dev *edev;
>
> - if (of_property_read_bool(dev->of_node, "extcon"))
> - return extcon_get_edev_by_phandle(dwc->dev, 0);
> + if (device_property_read_bool(dev, "extcon"))
> + return extcon_get_edev_by_phandle(dev, 0);
No reservations against any of the patches. What is the idea for getting
these merged upstream? I don't mind taking 4-5 through my tree, but what
are the other folks considering?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-12 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-12 11:47 [v1,4/5] usb: dwc3: drd: Switch to device property for 'extcon' handling Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2018-11-10 18:11 Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).