From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Joel Pepper <joel.pepper@rwth-aachen.de>,
Paul Elder <paul.elder@ideasonboard.com>,
linux-usb@vger.kernel.org
Subject: [v7] usb: gadget: uvc: configfs: Add bFrameIndex attributes
Date: Tue, 31 Jul 2018 20:46:52 +0300 [thread overview]
Message-ID: <87600vs3g3.fsf@linux.intel.com> (raw)
Hi,
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:
> Hi Felipe,
>
> On Thursday, 26 July 2018 13:49:07 EEST Felipe Balbi wrote:
>> Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:
>> > From: Joel Pepper <joel.pepper@rwth-aachen.de>
>> >
>> > - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size.
>> > - Automatically assign ascending bFrameIndex to each frame in a format.
>> >
>> > Before all "bFrameindex" attributes were set to "1" with no way to
>> > configure the gadget otherwise. This resulted in the host always
>> > negotiating for bFrameIndex 1 (i.e. the first framesize of the gadget).
>> > After the negotiation the host driver will set the user or application
>> > selected framesize, while the gadget is actually set to the first
>> > framesize.
>> >
>> > Now, when the containing format is linked into the streaming header,
>> > iterate over all child frame descriptors and assign ascending indices.
>> > The automatically assigned indices can be read from the new read only
>> > bFrameIndex configsfs attribute in each frame descriptor item.
>> >
>> > Signed-off-by: Joel Pepper <joel.pepper@rwth-aachen.de>
>> > [Simplified documentation, renamed function, blank space update]
>> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>
>> please rebase on testing/next, but give me a couple hours to go through
>> the rest of my inbox first ;)
>
> I will. Have you had time to go through the rest of your inbox now ? It's been
> a few hours already I suppose :-)
well, pull request was already pushed to Greg. We're already in -rc7,
too late for this merge window.
next reply other threads:[~2018-07-31 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 17:46 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-31 13:04 [v7] usb: gadget: uvc: configfs: Add bFrameIndex attributes Laurent Pinchart
2018-07-26 10:49 Felipe Balbi
2018-06-13 6:07 Joel Pepper
2018-06-12 22:58 Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87600vs3g3.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=joel.pepper@rwth-aachen.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-usb@vger.kernel.org \
--cc=paul.elder@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).