From: Felipe Balbi <balbi@kernel.org>
To: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
Cc: "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
John Youn <John.Youn@synopsys.com>
Subject: Re: [PATCH v3 3/4] usb: dwc3: Add device property sgl-trb-cache-size-quirk
Date: Mon, 06 Jul 2020 09:43:37 +0300 [thread overview]
Message-ID: <877dvhqh2e.fsf@kernel.org> (raw)
In-Reply-To: <5534d9d6-5452-dade-e46e-f4b0910becdb@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]
Hi,
Tejas Joglekar <Tejas.Joglekar@synopsys.com> writes:
>> @@ -95,6 +95,10 @@ int dwc3_host_init(struct dwc3 *dwc)
>> if (dwc->usb2_lpm_disable)
>> props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb2-lpm-disable");
>>
>> + if (dwc->sgl_trb_cache_size_quirk)
>> + props[prop_idx++] =
>> + PROPERTY_ENTRY_BOOL("sgl-trb-cache-size-quirk");
>> +
>> /**
>> * WORKAROUND: dwc3 revisions <=3.00a have a limitation
>> * where Port Disable command doesn't work.
>>
> Does this implementation looks good to you? Rob has some concerned over the DT entries,
> you suggested using compatible string with this quirk addition.
> Can you please brief about how you would like to have this quirk implemented?
> I can send the updated patch. My patch series is pending for merge just because of the
> DT and quirk issue. Can you please help?
Yeah, you need to get into an agreement with Rob :-) I don't mind having
extra DT flags for things which can't be detected in runtime, Rob
disagrees.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-07-06 6:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:40 [PATCH v3 0/4] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
2020-05-27 10:40 ` [PATCH v3 1/4] dt-bindings: usb: Add documentation for SG trb cache size quirk Tejas Joglekar
2020-05-29 18:05 ` Rob Herring
2020-05-27 10:41 ` [PATCH v3 2/4] usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK Tejas Joglekar
2020-05-27 10:41 ` [PATCH v3 3/4] usb: dwc3: Add device property sgl-trb-cache-size-quirk Tejas Joglekar
2020-07-06 5:07 ` Tejas Joglekar
2020-07-06 6:43 ` Felipe Balbi [this message]
2020-07-07 17:21 ` Tejas Joglekar
2020-07-12 13:45 ` Tejas Joglekar
2020-07-15 5:51 ` Tejas Joglekar
2020-07-21 9:47 ` Felipe Balbi
2020-07-21 16:57 ` Tejas Joglekar
2020-07-31 10:13 ` Tejas Joglekar
2020-08-04 0:44 ` Thinh Nguyen
2020-08-04 1:59 ` Jun Li
2020-05-27 10:42 ` [PATCH v3 4/4] usb: xhci: Use temporary buffer to consolidate SG Tejas Joglekar
2020-06-08 4:32 ` [PATCH v3 0/4] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
2020-06-09 8:57 ` Mathias Nyman
2020-06-11 18:07 ` Tejas Joglekar
2020-06-30 6:28 ` Tejas Joglekar
2020-07-23 10:35 ` Jun Li
2020-07-24 0:15 ` Tejas Joglekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dvhqh2e.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Tejas.Joglekar@synopsys.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).