From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
Jules Maselbas <jmaselbas@kalray.eu>,
Markus Reichl <m.reichl@fivetechno.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2] usb: dwc2: Use generic PHY width in params setup
Date: Tue, 18 Jun 2019 10:26:01 +0300 [thread overview]
Message-ID: <877e9jgxrq.fsf@linux.intel.com> (raw)
In-Reply-To: <0c370ba7-bb45-7580-1a60-021f15c1c37d@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]
Hi,
Marek Szyprowski <m.szyprowski@samsung.com> writes:
> Hi All,
>
> On 2019-05-31 14:44, Minas Harutyunyan wrote:
>> On 5/9/2019 1:16 PM, Jules Maselbas wrote:
>>> Setting params.phy_utmi_width in dwc2_lowlevel_hw_init() is pointless
>>> since
>>> it's value will be overwritten by dwc2_init_params().
>>>
>>> This change make sure to take in account the generic PHY width
>>> information
>>> during paraminitialisation, done in dwc2_set_param_phy_utmi_width().
>>>
>>> By doing so, the phy_utmi_width params can still be overrided by
>>> devicetree specific params and will also be checked against hardware
>>> capabilities.
>>>
>>> Fixes: 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif with
>>> phy_utmi_width")
>>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
>>
>> Acked-by: Minas Harutyunyan <hminas@synopsys.com>
>
> Gentle reminder, Felipe, could you take this to the fixes for v5.2?
darn it, I applied for 'next'. I'll remove from that branch and place it
in fixes. Pull request, hopefully, tomorrow.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2019-06-18 7:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190506130052eucas1p25afd4e15648e9efc6fd011e46081fbea@eucas1p2.samsung.com>
2019-05-03 20:49 ` [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width Krzysztof Kozlowski
2019-05-06 13:00 ` [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs Marek Szyprowski
2019-05-06 13:40 ` Jules Maselbas
2019-05-07 6:22 ` Minas Harutyunyan
2019-05-07 8:12 ` Markus Reichl
2019-05-07 9:17 ` Marek Szyprowski
2019-05-07 12:03 ` Marek Szyprowski
2019-05-07 12:38 ` Markus Reichl
2019-06-05 8:57 ` Krzysztof Kozlowski
2019-05-07 6:21 ` [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width Minas Harutyunyan
2019-05-07 6:43 ` Marek Szyprowski
2019-05-07 10:08 ` [PATCH] usb: dwc2: Use generic PHY width in params setup Jules Maselbas
2019-05-07 10:08 ` Jules Maselbas
2019-05-07 10:54 ` Marek Szyprowski
2019-05-09 9:15 ` [PATCH v2] " Jules Maselbas
2019-05-31 12:22 ` Jules Maselbas
2019-05-31 12:44 ` Minas Harutyunyan
2019-06-06 10:13 ` Marek Szyprowski
2019-06-18 7:26 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e9jgxrq.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=Minas.Harutyunyan@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmaselbas@kalray.eu \
--cc=linux-usb@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).