linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Andrey Konovalov <andreyknvl@google.com>,
	Alan Stern <stern@rowland.harvard.edu>
Cc: USB list <linux-usb@vger.kernel.org>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: Pass transfer_buffer to gadget drivers
Date: Fri, 07 Jun 2019 15:02:10 +0300	[thread overview]
Message-ID: <877e9xd2nx.fsf@linux.intel.com> (raw)
In-Reply-To: <CAAeHK+xRHB28N_VUbcCit=81+wKK=A9X3aA4rTa9aShy7b2Bnw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]


Hi,

Andrey Konovalov <andreyknvl@google.com> writes:
> I've noticed that when the host performs a control request,
> urb->transfer_buffer/transfer_buffer_length are not passed to the
> gadget drivers via the setup() call, the only thing that is passed is
> the usb_ctrlrequest struct. Is there a way to get the transfer_buffer
> from within a gadget driver? If not, what approach would the best to
> implement this?

I think you need to further explain what you mean here.

What do you mean by gadget driver in this case?

If you mean the drivers under drivers/usb/gadget/{function,legacy}
directories then there's no way that they can have access to anything
from the host.

Remember that gadget and host are two completely distinct units. The
only thing they share is a USB cable. When it comes to Control
Transfers, if a data stage is necessary, that must be encoded in the
wLength field of the control structure.

Also, host side does *not* pass its usb_ctrlrequest struct to the
gadget, it passes a series of 8 bytes which are oblivious to where in
memory they were from the host point of view.

If if you have the same machine acting as both host and device, each
side has no knowledge of that fact.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-06-07 12:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07 11:44 Pass transfer_buffer to gadget drivers Andrey Konovalov
2019-06-07 12:02 ` Felipe Balbi [this message]
2019-06-07 12:14   ` Andrey Konovalov
2019-06-07 12:25     ` Felipe Balbi
2019-06-07 12:32       ` Andrey Konovalov
2019-06-07 12:43         ` Felipe Balbi
2019-06-07 12:45           ` Andrey Konovalov
2019-06-07 14:04             ` Alan Stern
2019-06-07 14:38               ` Andrey Konovalov
2019-06-07 15:02                 ` Alan Stern
2019-06-07 15:05                   ` Andrey Konovalov
2019-06-18 13:31                     ` Andrey Konovalov
2019-06-18 13:34                       ` Andrey Konovalov
2019-06-18 13:53                         ` Alan Stern
2019-06-19  6:36                           ` Felipe Balbi
2019-06-28 16:44                           ` Andrey Konovalov
2019-06-28 17:29                             ` Andrey Konovalov
2019-06-28 18:07                               ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e9xd2nx.fsf@linux.intel.com \
    --to=felipe.balbi@linux.intel.com \
    --cc=andreyknvl@google.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).