From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <thinh.nguyen@synopsys.com>, linux-usb@vger.kernel.org
Cc: John Youn <john.youn@synopsys.com>
Subject: [v5,1/3] usb: dwc3: Track DWC_usb31 VERSIONTYPE
Date: Thu, 08 Nov 2018 09:10:36 +0200 [thread overview]
Message-ID: <877ehot577.fsf@linux.intel.com> (raw)
Hi,
Thinh Nguyen <thinh.nguyen@synopsys.com> writes:
> Add a new field to dwc3 structure to track VERSIONTYPE. The VERSIONTYPE
> is represented in ASCII in the 32-bit VERSIONTYPE register. In
> DWC_usb31, sub releases for each version are tracked with VERSIONTYPE
> such as "ea01" and "ea02".
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> ---
> drivers/usb/dwc3/core.c | 1 +
> drivers/usb/dwc3/core.h | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index becfbb87f791..437816ff8860 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -702,6 +702,7 @@ static bool dwc3_core_is_valid(struct dwc3 *dwc)
> /* Detected DWC_usb31 IP */
> dwc->revision = dwc3_readl(dwc->regs, DWC3_VER_NUMBER);
> dwc->revision |= DWC3_REVISION_IS_DWC31;
> + dwc->version_type = dwc3_readl(dwc->regs, DWC3_VER_TYPE);
> } else {
> return false;
> }
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 5bfb62533e0f..4573e1bfd56e 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -918,6 +918,7 @@ struct dwc3_scratchpad_array {
> * @u1u2: only used on revisions <1.83a for workaround
> * @maximum_speed: maximum speed requested (mainly for testing purposes)
> * @revision: revision register contents
> + * @version_type: VERSIONTYPE register contents, a sub release of a revision
> * @dr_mode: requested mode of operation
> * @current_dr_role: current role of operation when in dual-role mode
> * @desired_dr_role: desired role of operation when in dual-role mode
> @@ -1104,6 +1105,10 @@ struct dwc3 {
> #define DWC3_USB31_REVISION_110A (0x3131302a | DWC3_REVISION_IS_DWC31)
> #define DWC3_USB31_REVISION_120A (0x3132302a | DWC3_REVISION_IS_DWC31)
>
> + u32 version_type;
> +
> +#define DWC31_VERSIONTYPE_EA01 0x65613031
on patch 2 you talk about ea06, why don't you have a define for all
those version types?
next reply other threads:[~2018-11-08 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 7:10 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-08 19:41 [v5,1/3] usb: dwc3: Track DWC_usb31 VERSIONTYPE Thinh Nguyen
2018-11-08 3:51 Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ehot577.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=john.youn@synopsys.com \
--cc=linux-usb@vger.kernel.org \
--cc=thinh.nguyen@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).