From: Felipe Balbi <balbi@kernel.org>
To: "Fang, Yuan" <Yuan.Fang@verisilicon.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: 答复: [PATCH] driver/usb/dwc3: Add error handle for dwc3 get usb phy
Date: Thu, 10 Jun 2021 15:27:46 +0300 [thread overview]
Message-ID: <878s3h29bx.fsf@kernel.org> (raw)
In-Reply-To: <678AD2A4F5F78445B722FED0965FE327776E4011@SHASXM06.verisilicon.com>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
Hi,
(please don't top-post. Also, make sure your email client breaks lines
at 80 columns
"Fang, Yuan" <Yuan.Fang@verisilicon.com> writes:
> I agree with you that some platforms don't require a PHY driver.
>
> But in the case I mentioned, in the platforms that do need a PHY
> driver and PHY driver is not bring up successfully, the driver code
> right now will return 0 and go on set the dwc->phys_ready=ture, which
> looks odd in this case, right?
Your new PHY driver shouldn't return -ENODEV. You can see dwc3 filters
only -ENOSYS (framework disabled) and -ENODEV (device doesn't exist).
Stop returning -ENODEV and you should get the error propagated to dwc3
properly.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next prev parent reply other threads:[~2021-06-10 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 11:37 [PATCH] driver/usb/dwc3: Add error handle for dwc3 get usb phy Yuan Fang
2021-06-10 11:47 ` Felipe Balbi
2021-06-10 11:58 ` 答复: " Fang, Yuan
2021-06-10 12:27 ` Felipe Balbi [this message]
2021-06-10 12:08 ` Fang, Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s3h29bx.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=Yuan.Fang@verisilicon.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox