From: Felipe Balbi <balbi@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: 周琰杰 <zhouyanjie@wanyeetech.com>, 周正 <sernia.zhou@foxmail.com>,
漆鹏振 <aric.pzqi@ingenic.com>,
od@zcrc.me, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register
Date: Thu, 27 Aug 2020 17:26:40 +0300 [thread overview]
Message-ID: <878se0i2qn.fsf@kernel.org> (raw)
In-Reply-To: <HG6QFQ.KLMIR92DB2D02@crapouillou.net>
[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]
Hi,
Paul Cercueil <paul@crapouillou.net> writes:
>>>>> @@ -246,9 +241,8 @@ static void x1830_usb_phy_init(struct usb_phy
>>>>> *phy)
>>>>> USBPCR1_DMPD | USBPCR1_DPPD;
>>>>> writel(reg, priv->base + REG_USBPCR1_OFFSET);
>>>>>
>>>>> - reg = USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT
>>>>> | USBPCR_TXPREEMPHTUNE |
>>>>> + return USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT |
>>>>> USBPCR_TXPREEMPHTUNE |
>>>>> USBPCR_COMMONONN | USBPCR_POR;
>>>>> - writel(reg, priv->base + REG_USBPCR_OFFSET);
>>>>
>>>> not a bug fix
>>>
>>> Well, if you don't like my bug fix, next time wait for my
>>> Reviewed-by.
>>
>> why so angry? Take a break every once in a while. Besides, someone
>> else
>> already sent the oneliner before you ;-)
>
> I'm just pissed that this patch has not been tested. I don't like
> sloppy work.
yeah, s**t happens
>> In any case, why should I wait for your Reviewed-by? Get maintainer
>> doesn't list you as the maintainer for it. Do you want to update
>> MAINTAINERS by any chance?
>
> Yes, I thought I was (I'm maintainer of all Ingenic drivers), that also
> explains why I wasn't Cc'd for the oneliner patch you mentioned...
>
> IIRC Zhou has a patch to move the driver to drivers/phy/, I'll add
> myself as maintainer once it's moved there.
makes sense
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2020-08-27 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 12:43 [PATCH 0/1] USB: PHY: JZ4770: Next time, please test it Paul Cercueil
2020-08-27 12:43 ` [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register Paul Cercueil
2020-08-27 12:58 ` Felipe Balbi
2020-08-27 13:11 ` Paul Cercueil
2020-08-27 13:25 ` Felipe Balbi
2020-08-27 13:50 ` Paul Cercueil
2020-08-27 14:26 ` Felipe Balbi [this message]
2020-08-27 15:35 ` Zhou Yanjie
2020-09-09 10:23 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878se0i2qn.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=aric.pzqi@ingenic.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=sernia.zhou@foxmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).