Re: [PATCH v2] usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors

[Robert Jarzmik <robert.jarzmik@free.fr>]

Linus Walleij <linus.walleij@linaro.org> writes:

> Instead of using the legacy GPIO API and keeping track on
> polarity inversion semantics in the driver, switch to use
> GPIO descriptors for this driver and change all consumers
> in the process.
>
> This makes it possible to retire platform data completely:
> the only remaining platform data member was "wakeup" which
> was intended to make the vbus interrupt wakeup capable,
> but was not set by any users and thus remained unused. VBUS
> was not waking any devices up. Leave a comment about it so
> later developers using the platform can consider setting it
> to always enabled so plugging in USB wakes up the platform.
>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: Daniel Mack <daniel@zonque.org>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Acked-by: Felipe Balbi <balbi@kernel.org>
> Acked-by: Sylwester Nawrocki <snawrocki@kernel.org>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Fix a chip label typo in mach-s3c64xx
> - Collect the ACKs!

Hi Linus,

Throughout this patch, if I get it right, you suppose that :
 - the gpio_request() for the vbus is called as gpio_request(xx, gpio, "vbus")
 - the gpio_request() for the pullup is called as gpio_request(xx, gpio, "pullup")

My understanding from drivers/usb/phy/phy-gpio-vbus-usb.c is that these name are
:
 - "vbus_detect"
 - "udc_pullup"

Have I missed something ?

Cheers.

--
Robert