From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Hal Emmerich <hal@halemmerich.com>, linux-usb@vger.kernel.org
Subject: usb: dwc2: disable power_down on rockchip devices
Date: Tue, 02 Oct 2018 10:35:17 +0300 [thread overview]
Message-ID: <87a7nwajii.fsf@linux.intel.com> (raw)
Hi,
Hal Emmerich <hal@halemmerich.com> writes:
> From 04fbf78e4e569bf872f1ffcb0a6f9b89569dc913 Mon Sep 17 00:00:00 2001
> From: Hal Emmerich <hal@halemmerich.com>
> Date: Thu, 19 Jul 2018 21:48:08 -0500
> Subject: [PATCH] usb: dwc2: disable power_down on rockchip devices
>
> The bug would let the usb controller enter partial power down,
> which was formally known as hibernate, upon boot if nothing was plugged
> in to the port. Partial power down couldn't be exited properly, so any
> usb devices plugged in after boot would not be usable.
>
> Before the name change, params.hibernation was false by default, so
> _dwc2_hcd_suspend() would skip entering hibernation. With the
> rename, _dwc2_hcd_suspend() was changed to use params.power_down
> to decide whether or not to enter partial power down.
>
> Since params.power_down is non-zero by default, it needs to be set
> to 0 for rockchip devices to restore functionality.
>
> This bug was reported in the linux-usb thread:
> REGRESSION: usb: dwc2: USB device not seen after boot
>
> The commit that caused this regression is:
> 6d23ee9caa6790aea047f9aca7f3c03cb8d96eb6
>
> Signed-off-by: Hal Emmerich <hal@halemmerich.com>
> ---
> drivers/usb/dwc2/params.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index f03e41879224..492607adc506 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -82,6 +82,7 @@ static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
> p->host_perio_tx_fifo_size = 256;
> p->ahbcfg = GAHBCFG_HBSTLEN_INCR16 <<
> GAHBCFG_HBSTLEN_SHIFT;
> + p->power_down = 0;
> }
>
> static void dwc2_set_ltq_params(struct dwc2_hsotg *hsotg)
can't apply, badly formatted. Please resend using git send-email. Also
collect Minas' acked-by
next reply other threads:[~2018-10-02 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 7:35 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-21 20:53 usb: dwc2: disable power_down on rockchip devices Hal Emmerich
2018-10-03 1:58 Hal Emmerich
2018-10-01 5:55 Minas Harutyunyan
2018-09-28 14:07 Minas Harutyunyan
2018-09-28 2:58 Hal Emmerich
2018-09-13 6:52 Minas Harutyunyan
2018-09-13 6:52 Minas Harutyunyan
2018-09-12 15:21 Urja Rannikko
2018-07-20 3:25 Hal Emmerich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7nwajii.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=hal@halemmerich.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).